You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@jackrabbit.apache.org by st...@apache.org on 2005/04/19 12:00:38 UTC

svn commit: r161866 - incubator/jackrabbit/trunk/src/java/org/apache/jackrabbit/core/NodeImpl.java

Author: stefan
Date: Tue Apr 19 03:00:36 2005
New Revision: 161866

URL: http://svn.apache.org/viewcvs?view=rev&rev=161866
Log:
minor optimization: avoid unnecessary throwing & catching of exception

Modified:
    incubator/jackrabbit/trunk/src/java/org/apache/jackrabbit/core/NodeImpl.java

Modified: incubator/jackrabbit/trunk/src/java/org/apache/jackrabbit/core/NodeImpl.java
URL: http://svn.apache.org/viewcvs/incubator/jackrabbit/trunk/src/java/org/apache/jackrabbit/core/NodeImpl.java?view=diff&r1=161865&r2=161866
==============================================================================
--- incubator/jackrabbit/trunk/src/java/org/apache/jackrabbit/core/NodeImpl.java (original)
+++ incubator/jackrabbit/trunk/src/java/org/apache/jackrabbit/core/NodeImpl.java Tue Apr 19 03:00:36 2005
@@ -3717,9 +3717,7 @@
         // check state of this instance
         sanityCheck();
 
-        try {
-            checkLockable();
-        } catch (UnsupportedRepositoryOperationException  e) {
+        if (!isNodeType(MIX_LOCKABLE)) {
             // a node that is not lockable never holds a lock
             return false;
         }



Re: svn commit: r161866 - incubator/jackrabbit/trunk/src/java/org/apache/jackrabbit/core/NodeImpl.java

Posted by Marcel Reutegger <ma...@gmx.net>.
ok, das geht auch so ;)

gruess
  marcel

stefan@apache.org wrote:
> Author: stefan
> Date: Tue Apr 19 03:00:36 2005
> New Revision: 161866
> 
> URL: http://svn.apache.org/viewcvs?view=rev&rev=161866
> Log:
> minor optimization: avoid unnecessary throwing & catching of exception
> 
> Modified:
>     incubator/jackrabbit/trunk/src/java/org/apache/jackrabbit/core/NodeImpl.java
> 
> Modified: incubator/jackrabbit/trunk/src/java/org/apache/jackrabbit/core/NodeImpl.java
> URL: http://svn.apache.org/viewcvs/incubator/jackrabbit/trunk/src/java/org/apache/jackrabbit/core/NodeImpl.java?view=diff&r1=161865&r2=161866
> ==============================================================================
> --- incubator/jackrabbit/trunk/src/java/org/apache/jackrabbit/core/NodeImpl.java (original)
> +++ incubator/jackrabbit/trunk/src/java/org/apache/jackrabbit/core/NodeImpl.java Tue Apr 19 03:00:36 2005
> @@ -3717,9 +3717,7 @@
>          // check state of this instance
>          sanityCheck();
>  
> -        try {
> -            checkLockable();
> -        } catch (UnsupportedRepositoryOperationException  e) {
> +        if (!isNodeType(MIX_LOCKABLE)) {
>              // a node that is not lockable never holds a lock
>              return false;
>          }
> 
> 
> 

-- 
-----------------------------------------< marcel.reutegger@day.com >---
Marcel Reutegger, Day Software AG, Barfuesserplatz 6, CH - 4001 Basel
T +41 61 226 98 98, F +41 61 226 98 97
-----------------------------------------------< http://www.day.com >---