You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "hainenber (via GitHub)" <gi...@apache.org> on 2025/03/15 12:40:18 UTC
[PR] chore(build): prevent Dependabot opening PR to bump `prettier` [superset]
hainenber opened a new pull request, #32687:
URL: https://github.com/apache/superset/pull/32687
<!---
Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
Example:
fix(dashboard): load charts correctly
-->
chore(build): prevent Dependabot opening PR to bump `prettier`
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
Bumping versions for `prettier` in superset-frontend is a bit manually atm. Mere change in lockfile is not enough; we have to bump the version in pre-commit config and to actually run `npm run lint-fix` to get the codebase up to date with newer `prettier` baseline. This PR is to reduce a bit of maintenance hassle.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore(build): prevent Dependabot opening PR to bump `prettier` [superset]
Posted by "hainenber (via GitHub)" <gi...@apache.org>.
hainenber closed pull request #32687: chore(build): prevent Dependabot opening PR to bump `prettier`
URL: https://github.com/apache/superset/pull/32687
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore(build): prevent Dependabot opening PR to bump `prettier` [superset]
Posted by "hainenber (via GitHub)" <gi...@apache.org>.
hainenber commented on PR #32687:
URL: https://github.com/apache/superset/pull/32687#issuecomment-3016335295
Close for inactivity.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore(build): prevent Dependabot opening PR to bump `prettier` [superset]
Posted by "mistercrunch (via GitHub)" <gi...@apache.org>.
mistercrunch commented on PR #32687:
URL: https://github.com/apache/superset/pull/32687#issuecomment-2730112536
Pointing out that it's not a bad thing for dependabot to open a *failing* PR as it can be used as a signal that a newer version is out, and highlights what is failing. Then committers can add on to the branch to make it pass CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore(build): prevent Dependabot opening PR to bump `prettier` [superset]
Posted by "hainenber (via GitHub)" <gi...@apache.org>.
hainenber commented on PR #32687:
URL: https://github.com/apache/superset/pull/32687#issuecomment-2730145424
Agree on that one. Thats why I only refer to prettier-related PRs as they _usually_ failed due to added/changed rules.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org