You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-issues@hadoop.apache.org by "Arpit Agarwal (JIRA)" <ji...@apache.org> on 2015/11/10 23:15:11 UTC
[jira] [Comment Edited] (HDFS-9094) Add command line option to ask
NameNode reload configuration.
[ https://issues.apache.org/jira/browse/HDFS-9094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14999442#comment-14999442 ]
Arpit Agarwal edited comment on HDFS-9094 at 11/10/15 10:14 PM:
----------------------------------------------------------------
Thanks for the description [~xiaobingo]. My comments below.
# What do you think of adding a new {{ReconfigurationProtocol}} that can be extended by {{NameNodeProtocols}} and implemented by DataNode. There is no change to the wire protocols. This has other advantages:
## {{ClientNameNodeProtocol}} need not depend on {{ClientDataNodeProtocol}}. The existing definitions can be moved out of {{ClientDataNodeProtocol}} into {{ReconfigurationProtocol}}.
## Avoid code duplication e.g. ClientNamenodeProtocolTranslatorPB#getReconfigurationStatus and ClientDatanodeProtocolTranslatorPB#getReconfigurationStatus etc. These will move to {{RefreshProtocolTranslatorPB}} etc.
# Nitpick: for loop in ClientNamenodeProtocolServerSideTranslatorPB#listReconfigurableProperties can be replaced with {{builder.addAllName(server.listReconfigurableProperties())}}
# Nitpick: NN stub routines can throw UnsupportedOperationException instead of IOException.
was (Author: arpitagarwal):
Thanks for the description [~xiaobingo]. My comments below.
# What do you think of adding a new {{ReconfigurationProtocol}} that can be extended by {{NameNodeProtocols}} and implemented by DataNode. There is no change to the wire protocols. This has other advantages:
## {{ClientNameNodeProtocol}} need not include {{ClientDataNodeProtocol}}. The existing definitions can be moved out of {{ClientDataNodeProtocol}} into {{ReconfigurationProtocol}}.
## Avoid code duplication e.g. ClientNamenodeProtocolTranslatorPB#getReconfigurationStatus and ClientDatanodeProtocolTranslatorPB#getReconfigurationStatus etc. These will move to {{RefreshProtocolTranslatorPB}} etc.
# Nitpick: for loop in ClientNamenodeProtocolServerSideTranslatorPB#listReconfigurableProperties can be replaced with {{builder.addAllName(server.listReconfigurableProperties())}}
# Nitpick: NN stub routines can throw UnsupportedOperationException instead of IOException.
> Add command line option to ask NameNode reload configuration.
> -------------------------------------------------------------
>
> Key: HDFS-9094
> URL: https://issues.apache.org/jira/browse/HDFS-9094
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: namenode
> Affects Versions: 2.7.0
> Reporter: Xiaobing Zhou
> Assignee: Xiaobing Zhou
> Attachments: HDFS-9094.001.patch
>
>
> This work is going to add DFS admin command that allows reloading NameNode configuration. This is sibling work related to HDFS-6808.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)