[jira] Commented: (THRIFT-323) TJSONProtocol

["Michael Greene (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/THRIFT-323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12671872#action_12671872 ] 

Michael Greene commented on THRIFT-323:
---------------------------------------

I haven't tested this out yet, but a few things to note:

 * .NET already includes a Base64 codec -- did you try using this?
 * The rest of the C# libraries use tabs over spaces.  We should continue that way for consistency, although at some point I'd like to see it all converted to spaces.
 * We're not doing the Author thing anymore (although everyone is thankful for your contributions, of course) - please use the ASF header in all the files.

Excepting the Base64 issue, those are mainly finicky things -- the code looks good, and I'm looking forward to testing it out.  Are there any tests you can add?

> TJSONProtocol
> -------------
>
>                 Key: THRIFT-323
>                 URL: https://issues.apache.org/jira/browse/THRIFT-323
>             Project: Thrift
>          Issue Type: New Feature
>          Components: Library (C#)
>            Reporter: Fredrik Hedberg
>            Priority: Minor
>         Attachments: thrift-csharp-json-3.diff
>
>
> TJSONProtocol - shamelessly stolen from the Java library

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.