[GitHub] [hudi] codope commented on a diff in pull request #6694: [DO NOT MERGE][HUDI-4855] Add missing table configs for bootstrap in Deltastreamer

[GitBox <gi...@apache.org>]

codope commented on code in PR #6694:
URL: https://github.com/apache/hudi/pull/6694#discussion_r974236009


##########
hudi-utilities/src/main/java/org/apache/hudi/utilities/deltastreamer/BootstrapExecutor.java:
##########
@@ -191,11 +194,32 @@ private void initializeTable() throws IOException {
         .fromProperties(props)
         .setTableType(cfg.tableType)
         .setTableName(cfg.targetTableName)
+        .setRecordKeyFields(props.getString(KeyGeneratorOptions.RECORDKEY_FIELD_NAME.key()))
+        .setPartitionFields(props.getString(KeyGeneratorOptions.PARTITIONPATH_FIELD_NAME.key(), null))
+        .setPreCombineField(props.getString(HoodieWriteConfig.PRECOMBINE_FIELD_NAME.key()))

Review Comment:
   Probably, we need to set this in the test as well. I see some CI test failure due to precombine config not set in the test.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org