You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by "FMX (via GitHub)" <gi...@apache.org> on 2023/02/21 03:31:58 UTC

[GitHub] [incubator-celeborn] FMX opened a new pull request, #1254: [CELEBORN-320][Flink] fix handle wrong message type in FetchHandler.

FMX opened a new pull request, #1254:
URL: https://github.com/apache/incubator-celeborn/pull/1254

   ### What changes were proposed in this pull request?
   1. Correct fetch handler about readAndCredit.
   
   
   ### Why are the changes needed?
   1. To improve code readability.
   
   
   ### Does this PR introduce _any_ user-facing change?
   NO.
   
   
   ### How was this patch tested?
   UT.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-celeborn] codecov[bot] commented on pull request #1254: [CELEBORN-320][FLINK] fix handle wrong message type in FetchHandler.

Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #1254:
URL: https://github.com/apache/incubator-celeborn/pull/1254#issuecomment-1437817820

   # [Codecov](https://codecov.io/gh/apache/incubator-celeborn/pull/1254?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1254](https://codecov.io/gh/apache/incubator-celeborn/pull/1254?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8c0b639) into [main](https://codecov.io/gh/apache/incubator-celeborn/commit/d7798127c977f6f6eeb03fffc2cb72952ef0576a?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d779812) will **decrease** coverage by `0.02%`.
   > The diff coverage is `100.00%`.
   
   > :exclamation: Current head 8c0b639 differs from pull request most recent head 165b9ad. Consider uploading reports for the commit 165b9ad to get more accurate results
   
   ```diff
   @@             Coverage Diff              @@
   ##               main    #1254      +/-   ##
   ============================================
   - Coverage     27.11%   27.08%   -0.02%     
   + Complexity      811      807       -4     
   ============================================
     Files           214      214              
     Lines         18356    18352       -4     
     Branches       1997     1996       -1     
   ============================================
   - Hits           4975     4969       -6     
   + Misses        13054    13053       -1     
   - Partials        327      330       +3     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-celeborn/pull/1254?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [.../celeborn/service/deploy/worker/FetchHandler.scala](https://codecov.io/gh/apache/incubator-celeborn/pull/1254?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d29ya2VyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvY2VsZWJvcm4vc2VydmljZS9kZXBsb3kvd29ya2VyL0ZldGNoSGFuZGxlci5zY2FsYQ==) | `37.23% <100.00%> (+1.06%)` | :arrow_up: |
   | [...celeborn/service/deploy/master/SlotsAllocator.java](https://codecov.io/gh/apache/incubator-celeborn/pull/1254?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bWFzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jZWxlYm9ybi9zZXJ2aWNlL2RlcGxveS9tYXN0ZXIvU2xvdHNBbGxvY2F0b3IuamF2YQ==) | `69.27% <0.00%> (-2.45%)` | :arrow_down: |
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-celeborn] FMX merged pull request #1254: [CELEBORN-320][FLINK] fix handle wrong message type in FetchHandler.

Posted by "FMX (via GitHub)" <gi...@apache.org>.
FMX merged PR #1254:
URL: https://github.com/apache/incubator-celeborn/pull/1254


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org