You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by haosdent huang <ha...@gmail.com> on 2017/01/01 09:29:13 UTC
Re: Review Request 54821: Refactored Docker::run() to make it only
aware of docker cli options.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54821/#review160308
-----------------------------------------------------------
Fix it, then Ship it!
LGTM! Verfied in Ubuntu 14.04 and CentOS 7.
src/docker/docker.hpp (lines 138 - 145)
<https://reviews.apache.org/r/54821/#comment231432>
Nit: indent with 4 spaces.
src/tests/containerizer/docker_containerizer_tests.cpp (line 1327)
<https://reviews.apache.org/r/54821/#comment231433>
Nit: indent with 4 spaces.
- haosdent huang
On Dec. 31, 2016, 1:27 a.m., Zhitao Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54821/
> -----------------------------------------------------------
>
> (Updated Dec. 31, 2016, 1:27 a.m.)
>
>
> Review request for mesos, Xiaojian Huang, haosdent huang, and Jie Yu.
>
>
> Bugs: MESOS-6808
> https://issues.apache.org/jira/browse/MESOS-6808
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch creates a wrapper struct for all recognizable docker cli
> options, and separate logic of creating these options to a different
> common function.
>
> This also enables us to overcome gmock's 10 argument limit.
>
> No logic change happens in this refactoring patch.
>
>
> Diffs
> -----
>
> src/docker/docker.hpp 9093371afc8ea792ba94f61c6875703e547ea6b0
> src/docker/docker.cpp 472cb1b4dc2b0ac65721c732fca8ec70a7470f47
> src/docker/executor.cpp 9b5c469e2d0f33e228ec746711e6bc6ed352cbc7
> src/slave/containerizer/docker.cpp 7a8a7271b54af0b4dcdae7a2aa8a90a8a7d05fd6
> src/tests/containerizer/docker_containerizer_tests.cpp 4e3b67bbb989f9084dfdf4970839956dcb0caa0e
> src/tests/containerizer/docker_tests.cpp 9667d434486c1832f180a297a39a3d5dae6a26bd
> src/tests/mock_docker.hpp 829a760d54ad8c7b88256ae5df4c88c9fb18df71
> src/tests/mock_docker.cpp 02b6065a01e7e52b0edb38676dfb1bb475584502
>
> Diff: https://reviews.apache.org/r/54821/diff/
>
>
> Testing
> -------
>
> `make check` with ROOT and DOCKER filter.
>
>
> Thanks,
>
> Zhitao Li
>
>