[jira] [Commented] (CAMEL-23582) camel-github - align Exchange header constant names with Camel naming convention

["Andrea Cosentino (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CAMEL-23582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18082545#comment-18082545 ] 

Andrea Cosentino commented on CAMEL-23582:
------------------------------------------

camel-github is going to be removed, but this could be done on 4.18.x or 4.14.x too

> camel-github - align Exchange header constant names with Camel naming convention
> --------------------------------------------------------------------------------
>
>                 Key: CAMEL-23582
>                 URL: https://issues.apache.org/jira/browse/CAMEL-23582
>             Project: Camel
>          Issue Type: Improvement
>          Components: camel-github
>            Reporter: Andrea Cosentino
>            Assignee: Andrea Cosentino
>            Priority: Major
>             Fix For: 4.21.0
>
>
> {{GitHubConstants}} (shared by {{camel-github}} and {{camel-github2}}) defines producer-read header constants with values that look prefixed but use {{GitHub*}} rather than {{Camel*}}:
> * {{GITHUB_PULLREQUEST = "GitHubPullRequest"}} - PR number for close / comment / files
> * {{GITHUB_INRESPONSETO = "GitHubInResponseTo"}} - parent comment ID
> * {{GITHUB_PULLREQUEST_HEAD_COMMIT_SHA}} - target commit SHA
> * {{GITHUB_ISSUE_TITLE}} - created issue title
> These cross {{HeaderFilterStrategy}} boundaries; rename string values to {{CamelGitHub<Name>}}. Apply to both {{camel-github}} and {{camel-github2}} in one PR.
> h3. Fix shape
> Rename the *string value* of each producer-read header constant to {{Camel<Component><Name>}}; keep the Java field name unchanged so routes that reference the constants symbolically continue to compile and run. Update tests that use the literal string values; regenerate component catalog JSON and docs; add an upgrade-guide entry in {{camel-4x-upgrade-guide-4_21.adoc}} (and matching 4_18 / 4_14 for backports where the component existed in those branches).
> h3. References
> * Tracker: CAMEL-23577
> * Precedent (rename pattern): CAMEL-23526 (camel-cxf)
> * Alternative pattern (HeaderFilterStrategy approach): CAMEL-23532 (camel-vertx-websocket / camel-atmosphere-websocket / camel-iggy)



--
This message was sent by Atlassian Jira
(v8.20.10#820010)