You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2019/04/05 02:33:45 UTC
[GitHub] [incubator-pinot] snleee commented on a change in pull request
#4081: Support legacy time type in SegmentValidationAndRetentionConfig
snleee commented on a change in pull request #4081: Support legacy time type in SegmentValidationAndRetentionConfig
URL: https://github.com/apache/incubator-pinot/pull/4081#discussion_r272428269
##########
File path: pinot-common/src/main/java/org/apache/pinot/common/config/SegmentsValidationAndRetentionConfig.java
##########
@@ -86,12 +88,17 @@ public void setTimeColumnName(String timeColumnName) {
this.timeColumnName = timeColumnName;
}
- public String getTimeType() {
- return timeType;
+ public TimeUnit getTimeType() {
+ return _timeType;
+ }
+
+ @JsonIgnore
+ public void setTimeType(TimeUnit timeType) {
Review comment:
I guess this is for completeness? (seems to be not used)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org