You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2017/06/08 23:18:20 UTC
Review Request 59935: Introduced a streaming function for a vector.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59935/
-----------------------------------------------------------
Review request for mesos, Benjamin Bannier, Benjamin Mahler, and Jan Schlicht.
Repository: mesos
Description
-------
Introduced a streaming function for a vector.
Diffs
-----
include/mesos/type_utils.hpp c7872c0cd7f19d923e8be1f33a775d5eb17a0cf7
src/common/type_utils.cpp 5f8e72b97d6766f9729079f6c6c013bc117cedb9
Diff: https://reviews.apache.org/r/59935/diff/1/
Testing
-------
make check
Thanks,
Jie Yu
Re: Review Request 59935: Introduced a streaming function for a
vector.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59935/#review177468
-----------------------------------------------------------
include/mesos/type_utils.hpp
Lines 377 (patched)
<https://reviews.apache.org/r/59935/#comment251049>
We should make equivalent cleanups in v1.
- Benjamin Bannier
On June 9, 2017, 1:18 a.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59935/
> -----------------------------------------------------------
>
> (Updated June 9, 2017, 1:18 a.m.)
>
>
> Review request for mesos, Benjamin Bannier, Benjamin Mahler, and Jan Schlicht.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Introduced a streaming function for a vector.
>
>
> Diffs
> -----
>
> include/mesos/type_utils.hpp c7872c0cd7f19d923e8be1f33a775d5eb17a0cf7
> src/common/type_utils.cpp 5f8e72b97d6766f9729079f6c6c013bc117cedb9
>
>
> Diff: https://reviews.apache.org/r/59935/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 59935: Introduced a streaming function for a
vector.
Posted by Jie Yu <yu...@gmail.com>.
> On June 9, 2017, 11:07 a.m., Benjamin Bannier wrote:
> > include/mesos/type_utils.hpp
> > Lines 382-384 (original), 394-396 (patched)
> > <https://reviews.apache.org/r/59935/diff/1/?file=1745732#file1745732line399>
> >
> > Not yours, but this one has a similar problem.
> >
> > I believe it should be possible to generalize this to e.g.,
> >
> > template <typename K, typename V>
> > std::ostream& operator<<(
> > std::ostream& stream,
> > const hashmap<K, V>& map)
> > {
> > return stream << stringify(map);
> > }
I'll address that later.
- Jie
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59935/#review177462
-----------------------------------------------------------
On June 26, 2017, 4:31 a.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59935/
> -----------------------------------------------------------
>
> (Updated June 26, 2017, 4:31 a.m.)
>
>
> Review request for mesos, Benjamin Bannier, Benjamin Mahler, and Jan Schlicht.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Introduced a streaming function for a vector.
>
>
> Diffs
> -----
>
> include/mesos/type_utils.hpp c7872c0cd7f19d923e8be1f33a775d5eb17a0cf7
> src/common/type_utils.cpp 5f8e72b97d6766f9729079f6c6c013bc117cedb9
>
>
> Diff: https://reviews.apache.org/r/59935/diff/2/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 59935: Introduced a streaming function for a
vector.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59935/#review177462
-----------------------------------------------------------
Fix it, then Ship it!
include/mesos/type_utils.hpp
Lines 382-384 (original), 394-396 (patched)
<https://reviews.apache.org/r/59935/#comment251044>
Not yours, but this one has a similar problem.
I believe it should be possible to generalize this to e.g.,
template <typename K, typename V>
std::ostream& operator<<(
std::ostream& stream,
const hashmap<K, V>& map)
{
return stream << stringify(map);
}
- Benjamin Bannier
On June 9, 2017, 1:18 a.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59935/
> -----------------------------------------------------------
>
> (Updated June 9, 2017, 1:18 a.m.)
>
>
> Review request for mesos, Benjamin Bannier, Benjamin Mahler, and Jan Schlicht.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Introduced a streaming function for a vector.
>
>
> Diffs
> -----
>
> include/mesos/type_utils.hpp c7872c0cd7f19d923e8be1f33a775d5eb17a0cf7
> src/common/type_utils.cpp 5f8e72b97d6766f9729079f6c6c013bc117cedb9
>
>
> Diff: https://reviews.apache.org/r/59935/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 59935: Introduced a streaming function for a
vector.
Posted by Jan Schlicht <ja...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59935/#review179343
-----------------------------------------------------------
Ship it!
Ship It!
- Jan Schlicht
On June 30, 2017, 5:54 a.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59935/
> -----------------------------------------------------------
>
> (Updated June 30, 2017, 5:54 a.m.)
>
>
> Review request for mesos, Benjamin Bannier, Benjamin Mahler, and Jan Schlicht.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Introduced a streaming function for a vector.
>
>
> Diffs
> -----
>
> include/mesos/type_utils.hpp c7872c0cd7f19d923e8be1f33a775d5eb17a0cf7
> include/mesos/v1/mesos.hpp c2e6ec5c4fa06d0179d6aaf3371ace4b6e6dbdaf
> src/common/type_utils.cpp 5f8e72b97d6766f9729079f6c6c013bc117cedb9
> src/v1/mesos.cpp 3b9f9b43e748159ae753880bbe4a5975814073ab
>
>
> Diff: https://reviews.apache.org/r/59935/diff/3/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 59935: Introduced a streaming function for a
vector.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59935/
-----------------------------------------------------------
(Updated June 30, 2017, 3:54 a.m.)
Review request for mesos, Benjamin Bannier, Benjamin Mahler, and Jan Schlicht.
Changes
-------
Addressed comments.
Repository: mesos
Description
-------
Introduced a streaming function for a vector.
Diffs (updated)
-----
include/mesos/type_utils.hpp c7872c0cd7f19d923e8be1f33a775d5eb17a0cf7
include/mesos/v1/mesos.hpp c2e6ec5c4fa06d0179d6aaf3371ace4b6e6dbdaf
src/common/type_utils.cpp 5f8e72b97d6766f9729079f6c6c013bc117cedb9
src/v1/mesos.cpp 3b9f9b43e748159ae753880bbe4a5975814073ab
Diff: https://reviews.apache.org/r/59935/diff/3/
Changes: https://reviews.apache.org/r/59935/diff/2-3/
Testing
-------
make check
Thanks,
Jie Yu
Re: Review Request 59935: Introduced a streaming function for a
vector.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59935/
-----------------------------------------------------------
(Updated June 26, 2017, 4:31 a.m.)
Review request for mesos, Benjamin Bannier, Benjamin Mahler, and Jan Schlicht.
Changes
-------
Rebased.
Repository: mesos
Description
-------
Introduced a streaming function for a vector.
Diffs (updated)
-----
include/mesos/type_utils.hpp c7872c0cd7f19d923e8be1f33a775d5eb17a0cf7
src/common/type_utils.cpp 5f8e72b97d6766f9729079f6c6c013bc117cedb9
Diff: https://reviews.apache.org/r/59935/diff/2/
Changes: https://reviews.apache.org/r/59935/diff/1-2/
Testing
-------
make check
Thanks,
Jie Yu