[isis] branch master updated: ISIS-3201: remove ISIS-3070 hack

[ah...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

ahuber pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/isis.git


The following commit(s) were added to refs/heads/master by this push:
     new 53afae0cf4 ISIS-3201: remove ISIS-3070 hack
53afae0cf4 is described below

commit 53afae0cf430b3e57480e4337f46cc731b07bd1a
Author: Andi Huber <ah...@apache.org>
AuthorDate: Thu Sep 22 06:49:47 2022 +0200

    ISIS-3201: remove ISIS-3070 hack
---
 .../scalars/choices/ObjectChoiceFormComponent.java | 28 ----------------------
 1 file changed, 28 deletions(-)

diff --git a/viewers/wicket/ui/src/main/java/org/apache/isis/viewer/wicket/ui/components/scalars/choices/ObjectChoiceFormComponent.java b/viewers/wicket/ui/src/main/java/org/apache/isis/viewer/wicket/ui/components/scalars/choices/ObjectChoiceFormComponent.java
index 8cafa6ae01..a5ea4c6429 100644
--- a/viewers/wicket/ui/src/main/java/org/apache/isis/viewer/wicket/ui/components/scalars/choices/ObjectChoiceFormComponent.java
+++ b/viewers/wicket/ui/src/main/java/org/apache/isis/viewer/wicket/ui/components/scalars/choices/ObjectChoiceFormComponent.java
@@ -18,11 +18,9 @@
  */
 package org.apache.isis.viewer.wicket.ui.components.scalars.choices;
 
-import org.apache.wicket.ajax.form.AjaxFormComponentUpdatingBehavior;
 import org.apache.wicket.markup.html.form.FormComponentPanel;
 import org.wicketstuff.select2.Select2MultiChoice;
 
-import org.apache.isis.commons.internal.exceptions._Exceptions;
 import org.apache.isis.core.metamodel.object.ManagedObject;
 import org.apache.isis.viewer.wicket.ui.components.widgets.formcomponent.CancelHintRequired;
 import org.apache.isis.viewer.wicket.ui.components.widgets.formcomponent.FormComponentPanelAbstract;
@@ -41,13 +39,6 @@ implements CancelHintRequired  {
         setType(ManagedObject.class);
     }
 
-    @Override
-    public void validate() {
-        if(shouldValidate()) {
-            super.validate();
-        }
-    }
-
     /**
      * Necessary because {@link FormComponentPanel} overrides this as <tt>true</tt>,
      * whereas we want to
@@ -78,23 +69,4 @@ implements CancelHintRequired  {
         // no-op
     }
 
-    // -- HELPER
-
-    /**
-     * [ISIS-3070]
-     * Skip validation if one of the callers is an {@link AjaxFormComponentUpdatingBehavior},
-     * as this validation might be called too early,
-     * when the pending value is not yet updated to the user's (new) input.
-     * Instead wait for the AjaxFormComponentUpdatingBehavior, which happens later,
-     * when the actual pending value is available for validation.
-     * <p>
-     * This is a hack, for the lack of a better solution yet.
-     */
-    private boolean shouldValidate() {
-        return !_Exceptions
-        .streamStackTrace()
-        .anyMatch(element->
-                    element.getClassName().contains(AjaxFormComponentUpdatingBehavior.class.getSimpleName()));
-    }
-
 }