You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by GitBox <gi...@apache.org> on 2020/09/30 00:01:04 UTC

[GitHub] [trafficserver] GeorgeHahn opened a new pull request #7229: Schedule `INKContInternal` destruction on local queue

GeorgeHahn opened a new pull request #7229:
URL: https://github.com/apache/trafficserver/pull/7229


   This event is being scheduled on the current `EThread`, so the signalling `schedule` call should be unnecessary. Use the non-signalling `_local` function instead.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficserver] randall commented on pull request #7229: Schedule `INKContInternal` destruction on local queue

Posted by GitBox <gi...@apache.org>.
randall commented on pull request #7229:
URL: https://github.com/apache/trafficserver/pull/7229#issuecomment-701443016


   [approve ci autest]


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficserver] GeorgeHahn closed pull request #7229: Schedule `INKContInternal` destruction on local queue

Posted by GitBox <gi...@apache.org>.
GeorgeHahn closed pull request #7229:
URL: https://github.com/apache/trafficserver/pull/7229


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficserver] masaori335 commented on pull request #7229: Schedule `INKContInternal` destruction on local queue

Posted by GitBox <gi...@apache.org>.
masaori335 commented on pull request #7229:
URL: https://github.com/apache/trafficserver/pull/7229#issuecomment-701102205


   [approve ci]
   [approve ci docs]


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficserver] GeorgeHahn commented on a change in pull request #7229: Schedule `INKContInternal` destruction on local queue

Posted by GitBox <gi...@apache.org>.
GeorgeHahn commented on a change in pull request #7229:
URL: https://github.com/apache/trafficserver/pull/7229#discussion_r497644741



##########
File path: src/traffic_server/InkAPI.cc
##########
@@ -1099,7 +1099,7 @@ INKContInternal::destroy()
     // action is needed.
     //
     if (p) {
-      p->schedule_imm(this);
+      p->schedule_imm_local(this);
     }

Review comment:
       Ah, good catch. I originally wrote this on 7.1.x, where that code didn't exist yet. I'll close this PR because it doesn't appear to be useful on 9.0.x and up.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficserver] ywkaras commented on a change in pull request #7229: Schedule `INKContInternal` destruction on local queue

Posted by GitBox <gi...@apache.org>.
ywkaras commented on a change in pull request #7229:
URL: https://github.com/apache/trafficserver/pull/7229#discussion_r497639308



##########
File path: src/traffic_server/InkAPI.cc
##########
@@ -1099,7 +1099,7 @@ INKContInternal::destroy()
     // action is needed.
     //
     if (p) {
-      p->schedule_imm(this);
+      p->schedule_imm_local(this);
     }

Review comment:
       I doesn't look to me like this is really changing effective behavior.  schedule_imm() calls schedule(), which will enqueue locally anyway because p == this_ethread():  https://github.com/apache/trafficserver/blob/fef47d7919e0f87e4f650dfb26742c3a0482091b/iocore/eventsystem/P_UnixEThread.h#L96 .
   
   @duke8253  ?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org