You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/10/13 09:00:14 UTC
[GitHub] [tvm] shingjan opened a new pull request, #13061: [Torch] Fix torch contrib issues
shingjan opened a new pull request, #13061:
URL: https://github.com/apache/tvm/pull/13061
This PR intends to fix import issues of the contrib torch lib and add warning.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tvm-bot commented on pull request #13061: [Torch] Fix torch contrib issues
Posted by GitBox <gi...@apache.org>.
tvm-bot commented on PR #13061:
URL: https://github.com/apache/tvm/pull/13061#issuecomment-1277274895
<!---bot-comment-->
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from [Reviewers](https://github.com/apache/incubator-tvm/blob/master/CONTRIBUTORS.md#reviewers) by @-ing them in a comment.
<sub>Generated by [tvm-bot](https://github.com/apache/tvm/blob/main/ci/README.md#github-actions)</sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] masahi merged pull request #13061: [Torch] Fix torch contrib issues
Posted by GitBox <gi...@apache.org>.
masahi merged PR #13061:
URL: https://github.com/apache/tvm/pull/13061
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] junrushao commented on a diff in pull request #13061: [Torch] Fix torch contrib issues
Posted by GitBox <gi...@apache.org>.
junrushao commented on code in PR #13061:
URL: https://github.com/apache/tvm/pull/13061#discussion_r994928518
##########
python/tvm/contrib/torch/as_torch.py:
##########
@@ -63,7 +63,7 @@ def tune(
database: ms.Database.DatabaseType = "json",
cost_model: ms.CostModel.CostModelType = "xgb",
measure_callbacks: ms.MeasureCallback.CallbackListType = "default",
- task_scheduler: ms.TaskScheduler.TaskSchedulerType = "round-robin",
+ task_scheduler: ms.task_scheduler.TaskScheduler.TaskSchedulerType = "round-robin",
Review Comment:
please import `TaskScheduler` here: https://github.com/apache/tvm/blob/main/python/tvm/meta_schedule/__init__.py
It's likely a typo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] yelite commented on a diff in pull request #13061: [Torch] Fix torch contrib issues
Posted by GitBox <gi...@apache.org>.
yelite commented on code in PR #13061:
URL: https://github.com/apache/tvm/pull/13061#discussion_r994602762
##########
python/tvm/contrib/torch/as_torch.py:
##########
@@ -63,7 +63,7 @@ def tune(
database: ms.Database.DatabaseType = "json",
cost_model: ms.CostModel.CostModelType = "xgb",
measure_callbacks: ms.MeasureCallback.CallbackListType = "default",
- task_scheduler: ms.TaskScheduler.TaskSchedulerType = "round-robin",
+ task_scheduler: ms.task_scheduler.TaskScheduler.TaskSchedulerType = "round-robin",
space: ms.SpaceGenerator.SpaceGeneratorType = "post-order-apply",
strategy: ms.SearchStrategy.SearchStrategyType = "replay_trace",
Review Comment:
```suggestion
strategy: ms.SearchStrategy.SearchStrategyType = "replay-trace",
```
There is a typo here in the original code
##########
python/tvm/contrib/torch/as_torch.py:
##########
@@ -63,7 +63,7 @@ def tune(
database: ms.Database.DatabaseType = "json",
cost_model: ms.CostModel.CostModelType = "xgb",
measure_callbacks: ms.MeasureCallback.CallbackListType = "default",
- task_scheduler: ms.TaskScheduler.TaskSchedulerType = "round-robin",
+ task_scheduler: ms.task_scheduler.TaskScheduler.TaskSchedulerType = "round-robin",
Review Comment:
I am thinking about putting `TaskScheduler` into the `ms` module. I cannot find the reason that `TaskScheduler` doesn't belong to the top level `meta_schedule` module like other classes do. @junrushao Your thought?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] shingjan commented on a diff in pull request #13061: [Torch] Fix torch contrib issues
Posted by GitBox <gi...@apache.org>.
shingjan commented on code in PR #13061:
URL: https://github.com/apache/tvm/pull/13061#discussion_r994926643
##########
python/tvm/contrib/torch/as_torch.py:
##########
@@ -63,7 +63,7 @@ def tune(
database: ms.Database.DatabaseType = "json",
cost_model: ms.CostModel.CostModelType = "xgb",
measure_callbacks: ms.MeasureCallback.CallbackListType = "default",
- task_scheduler: ms.TaskScheduler.TaskSchedulerType = "round-robin",
+ task_scheduler: ms.task_scheduler.TaskScheduler.TaskSchedulerType = "round-robin",
Review Comment:
Yeah that is good point. I thought about it but realize that maybe we don't want to expose the `TaskScheduler` api to ms-level with the refactoring @junrushao sent it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] junrushao commented on a diff in pull request #13061: [Torch] Fix torch contrib issues
Posted by GitBox <gi...@apache.org>.
junrushao commented on code in PR #13061:
URL: https://github.com/apache/tvm/pull/13061#discussion_r994928518
##########
python/tvm/contrib/torch/as_torch.py:
##########
@@ -63,7 +63,7 @@ def tune(
database: ms.Database.DatabaseType = "json",
cost_model: ms.CostModel.CostModelType = "xgb",
measure_callbacks: ms.MeasureCallback.CallbackListType = "default",
- task_scheduler: ms.TaskScheduler.TaskSchedulerType = "round-robin",
+ task_scheduler: ms.task_scheduler.TaskScheduler.TaskSchedulerType = "round-robin",
Review Comment:
please import `TaskScheduler` here: https://github.com/apache/tvm/blob/main/python/tvm/meta_schedule/__init__.py
It's likely a typo that i or anyone else mistakenly removed the import
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org