[jira] Commented: (THRIFT-226) Collections with binary keys or values break equals()

["Nathan Marz (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/THRIFT-226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12776637#action_12776637 ] 

Nathan Marz commented on THRIFT-226:
------------------------------------

I am for using ByteBuffer for the binary type. It's really the only good long-term solution, and I'm fine with it being non-backwards compatible. byte[] are just a giant pain to deal with right now and cause a lot of issues.

> Collections with binary keys or values break equals()
> -----------------------------------------------------
>
>                 Key: THRIFT-226
>                 URL: https://issues.apache.org/jira/browse/THRIFT-226
>             Project: Thrift
>          Issue Type: Bug
>          Components: Compiler (Java)
>            Reporter: Bryan Duxbury
>             Fix For: 0.2
>
>
> In Java, byte[].equals tests object equality, not value equality. As a result, if you have two list<binary> (or set<binary>, or map<binary, binary> with the same values and you do TBase.equals(), two structs that match by value won't return true. If we're going to do value equality, which I think we should, then we should make this consistent with collection types.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.