You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@asterixdb.apache.org by "Michael Blow (Code Review)" <do...@asterixdb.incubator.apache.org> on 2018/05/01 21:07:21 UTC

Change in asterixdb[master]: [ASTERIXDB-2370][*DB] Modify the inconsistent method name "i...

Hello Anon. E. Moose #1000171, Jenkins,

I'd like you to reexamine a change.  Please visit

    https://asterix-gerrit.ics.uci.edu/2629

to look at the new patch set (#5).

Change subject: [ASTERIXDB-2370][*DB] Modify the inconsistent method name "isFull"
......................................................................

[ASTERIXDB-2370][*DB] Modify the inconsistent method name "isFull"

- taken from https://github.com/apache/asterixdb/pull/7

The method is named as "isFull". However, the method does set the boolean
variable full.  Thus, rename the method as "setFull" should be more
intuitive than "isFull" since "isFull" is a query asking whether the 
object is full or not.

Change-Id: I99bf451367171afb3fc0511a6170eb4c492fc69f
---
M asterixdb/asterix-replication/src/main/java/org/apache/asterix/replication/logging/ReplicationLogBuffer.java
M asterixdb/asterix-replication/src/main/java/org/apache/asterix/replication/management/LogReplicationManager.java
2 files changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/29/2629/5
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2629
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I99bf451367171afb3fc0511a6170eb4c492fc69f
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow <mb...@apache.org>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>