You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by gi...@git.apache.org on 2017/08/31 17:53:22 UTC

[GitHub] merlimat commented on a change in pull request #736: Issue #735: Event Time support in c++ client

merlimat commented on a change in pull request #736: Issue #735: Event Time support in c++ client
URL: https://github.com/apache/incubator-pulsar/pull/736#discussion_r136404042
 
 

 ##########
 File path: pulsar-client-cpp/include/pulsar/MessageBuilder.h
 ##########
 @@ -71,6 +71,11 @@ class MessageBuilder {
     MessageBuilder& setPartitionKey(const std::string& partitionKey);
 
     /**
+     * Set the event timestamp for the message.
+     */
+    MessageBuilder& setEventTimestamp(uint64_t event_timestamp);
 
 Review comment:
   Nitpick: in C++ code we've been using camelCase for classes and var names, like `eventTimestamp`
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services