You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "nuttxs (via GitHub)" <gi...@apache.org> on 2024/09/25 08:57:40 UTC
[PR] xtensa/esp32s3: Adding the ioctl interface ota_set_bootseq() [nuttx]
nuttxs opened a new pull request, #13601:
URL: https://github.com/apache/nuttx/pull/13601
## Summary
arch/xtensa/esp32s3: Adding an ioctl interface ota_invalidate_bootseq() to the ESP32-S3 partitions, by deleting the corresponding
otadata, makes the boot sequence (ota_0/1) invalid.
## Impact
Only esp32s3
## Testing
Testing use esp32s3-devkitc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] xtensa/esp32s3: Adding the ioctl interface ota_set_bootseq() [nuttx]
Posted by "nuttxpr (via GitHub)" <gi...@apache.org>.
nuttxpr commented on PR #13601:
URL: https://github.com/apache/nuttx/pull/13601#issuecomment-2373528099
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues)
**Yes, the PR generally meets NuttX requirements.**
**Concise Feedback:**
* **Summary:** Clear and informative.
* **Impact:** Specifies the affected architecture. Could elaborate slightly: "Adds an ioctl interface `ota_invalidate_bootseq()` specific to the ESP32-S3, allowing invalidation of the OTA boot sequence."
* **Testing:** Provides basic testing information. Consider adding:
* Build host details (OS, compiler)
* More specific testing steps/commands used
* Snippets of relevant log output showcasing the behavior change
**Minor Suggestions:**
* Include links to any relevant ESP32-S3 documentation that informed the implementation.
* In the "Testing" section, clearly state that the functionality worked as expected (or if any issues were encountered).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] xtensa/esp32s3: Adding the ioctl interface ota_set_bootseq() [nuttx]
Posted by "nuttxs (via GitHub)" <gi...@apache.org>.
nuttxs commented on PR #13601:
URL: https://github.com/apache/nuttx/pull/13601#issuecomment-2375759234
Hi @tmedicci
The differences between simple boot and MCU boot are quite significant when compared to legacy boot, especially regarding features such as PARTITION_TABLE and PHY. Moreover, there are numerous internal partitions, which result in a broad range of adaptation and debugging requirements. We have previously communicated with espressif to confirm the use of legacy boot.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] xtensa/esp32s3: Adding the ioctl interface ota_set_bootseq() [nuttx]
Posted by "tmedicci (via GitHub)" <gi...@apache.org>.
tmedicci commented on PR #13601:
URL: https://github.com/apache/nuttx/pull/13601#issuecomment-2373806470
Hi @nuttxs , why not use MCUboot to deal with OTA in NuttX?
We highly recommend not using the legacy partition model as it requires the legacy bootloader (a.k.a IDF bootloader), which is no longer supported.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] xtensa/esp32s3: Adding the ioctl interface ota_set_bootseq() [nuttx]
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 merged PR #13601:
URL: https://github.com/apache/nuttx/pull/13601
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org