You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by zentol <gi...@git.apache.org> on 2018/07/19 11:50:48 UTC

[GitHub] flink pull request #6374: [FLINK-9895][tests] Ensure error logging for Netty...

GitHub user zentol opened a pull request:

    https://github.com/apache/flink/pull/6374

    [FLINK-9895][tests] Ensure error logging for NettyLeakDetectionResource

    ## What is the purpose of the change
    
    This PR is a small addition to #6363 to ensure that ERROR logging is enabled for Nettys `ResourceLeakDetector`, as otherwise the the leak will not cause test failures.
    
    ## Verifying this change
    
    * disable error logging in `flink-runtime` for `ResourceLeakDetector`. (see `log4j-test.properties`)
    * disable auto-release in `FileUploadHandler`
    * run `FileUploadHandlerTest`

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zentol/flink 9895

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/6374.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #6374
    
----
commit 373d6ef65b50de86897a9da6d403982aae59a3d1
Author: zentol <ch...@...>
Date:   2018-07-19T11:47:53Z

    [FLINK-9895][tests] Ensure error logging for NettyLeakDetectionResource

----


---

[GitHub] flink issue #6374: [FLINK-9895][tests] Ensure error logging for NettyLeakDet...

Posted by yanghua <gi...@git.apache.org>.
Github user yanghua commented on the issue:

    https://github.com/apache/flink/pull/6374
  
    +1


---

[GitHub] flink pull request #6374: [FLINK-9895][tests] Ensure error logging for Netty...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/6374


---