You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@geode.apache.org by up...@apache.org on 2018/01/11 18:49:52 UTC

[geode] branch develop updated: GEODE-4255: Remove mandatory failure on macOS.

This is an automated email from the ASF dual-hosted git repository.

upthewaterspout pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/geode.git


The following commit(s) were added to refs/heads/develop by this push:
     new a4329ad  GEODE-4255: Remove mandatory failure on macOS.
a4329ad is described below

commit a4329ad497a3f2589f46fd70ae2097c89f1278ec
Author: Sarge <md...@pivotal.io>
AuthorDate: Mon Jan 8 14:58:59 2018 -0800

    GEODE-4255: Remove mandatory failure on macOS.
---
 .../internal/cache/wan/misc/WANConfigurationJUnitTest.java     | 10 +++-------
 1 file changed, 3 insertions(+), 7 deletions(-)

diff --git a/geode-wan/src/test/java/org/apache/geode/internal/cache/wan/misc/WANConfigurationJUnitTest.java b/geode-wan/src/test/java/org/apache/geode/internal/cache/wan/misc/WANConfigurationJUnitTest.java
index 7065b65..8e7be1e 100644
--- a/geode-wan/src/test/java/org/apache/geode/internal/cache/wan/misc/WANConfigurationJUnitTest.java
+++ b/geode-wan/src/test/java/org/apache/geode/internal/cache/wan/misc/WANConfigurationJUnitTest.java
@@ -418,16 +418,12 @@ public class WANConfigurationJUnitTest {
   }
 
   /**
-   * This test takes a minimum of 120s to execute. It is known to hang on Mac OS X Yosemite do to
-   * changes in the the message string checked in GatewayReceiverImpl around line 167. Expects
-   * "Cannot assign requested address" but gets "Can't assign requested address". Timeout after 150s
-   * to safeguard against hanging on other platforms that may differ.
+   * This test takes a minimum of 120s to execute. Based on the experiences of the Yosemite release
+   * of macOS, timeout after 150s to safeguard against hanging on other platforms that may have
+   * different error messages.
    */
   @Test(timeout = 150000)
   public void test_ValidateGatewayReceiverAttributes_WrongBindAddress() {
-    if (System.getProperty("os.name").equals("Mac OS X")) {
-      fail("Failing to avoid known hang on Mac OS X.");
-    }
     cache = new CacheFactory().set(MCAST_PORT, "0").create();
     GatewayReceiverFactory fact = cache.createGatewayReceiverFactory();
     fact.setStartPort(50504);

-- 
To stop receiving notification emails like this one, please contact
['"commits@geode.apache.org" <co...@geode.apache.org>'].