You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Martin Grigorov (JIRA)" <ji...@apache.org> on 2012/09/20 13:19:08 UTC
[jira] [Created] (WICKET-4774) Introduce read-only interface for
PageParameters
Martin Grigorov created WICKET-4774:
---------------------------------------
Summary: Introduce read-only interface for PageParameters
Key: WICKET-4774
URL: https://issues.apache.org/jira/browse/WICKET-4774
Project: Wicket
Issue Type: Improvement
Components: wicket
Affects Versions: 6.0.0
Reporter: Martin Grigorov
Cuurently org.apache.wicket.Page#getPageParameters() and org.apache.wicket.request.resource.IResource.Attributes#getParameters() return a mutable PageParameters. For the latter this is not a problem since it is not stored and reused for url generation.
In the case with Page#getPageParameters() this instance is live until the page instance is alive. Some users make a mistake to modify the parameters (by using #add, #set, #remove) just to create an Url for some other page and later page's pageparameters are no more the real ones.
We can improve that by introducing an interface with getter methods only.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (WICKET-4774) Introduce read-only interface for
PageParameters
Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4774?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martin Grigorov updated WICKET-4774:
------------------------------------
Attachment: WICKET-4774.patch
> Introduce read-only interface for PageParameters
> ------------------------------------------------
>
> Key: WICKET-4774
> URL: https://issues.apache.org/jira/browse/WICKET-4774
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 6.0.0
> Reporter: Martin Grigorov
> Fix For: 7.0
>
> Attachments: WICKET-4774.patch
>
>
> Cuurently org.apache.wicket.Page#getPageParameters() and org.apache.wicket.request.resource.IResource.Attributes#getParameters() return a mutable PageParameters. For the latter this is not a problem since it is not stored and reused for url generation.
> In the case with Page#getPageParameters() this instance is live until the page instance is alive. Some users make a mistake to modify the parameters (by using #add, #set, #remove) just to create an Url for some other page and later page's pageparameters are no more the real ones.
> We can improve that by introducing an interface with getter methods only.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (WICKET-4774) Introduce read-only interface for
PageParameters
Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4774?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martin Grigorov updated WICKET-4774:
------------------------------------
Fix Version/s: 7.0
> Introduce read-only interface for PageParameters
> ------------------------------------------------
>
> Key: WICKET-4774
> URL: https://issues.apache.org/jira/browse/WICKET-4774
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 6.0.0
> Reporter: Martin Grigorov
> Fix For: 7.0
>
>
> Cuurently org.apache.wicket.Page#getPageParameters() and org.apache.wicket.request.resource.IResource.Attributes#getParameters() return a mutable PageParameters. For the latter this is not a problem since it is not stored and reused for url generation.
> In the case with Page#getPageParameters() this instance is live until the page instance is alive. Some users make a mistake to modify the parameters (by using #add, #set, #remove) just to create an Url for some other page and later page's pageparameters are no more the real ones.
> We can improve that by introducing an interface with getter methods only.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira