You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jclouds.apache.org by Andrew Bayer <no...@github.com> on 2013/08/01 21:27:37 UTC
[jclouds] Remove async from glesys (#88)
You can merge this Pull Request by running:
git pull https://github.com/abayer/jclouds-1 deasync-glesys
Or you can view, comment on it, or merge it online at:
https://github.com/jclouds/jclouds/pull/88
-- Commit Summary --
* Remove async from glesys
-- File Changes --
M providers/glesys/src/main/java/org/jclouds/glesys/GleSYSApi.java (1)
M providers/glesys/src/main/java/org/jclouds/glesys/GleSYSApiMetadata.java (23)
D providers/glesys/src/main/java/org/jclouds/glesys/GleSYSAsyncApi.java (71)
M providers/glesys/src/main/java/org/jclouds/glesys/compute/GleSYSComputeServiceAdapter.java (16)
R providers/glesys/src/main/java/org/jclouds/glesys/config/GleSYSHttpApiModule.java (30)
M providers/glesys/src/main/java/org/jclouds/glesys/features/ArchiveApi.java (64)
D providers/glesys/src/main/java/org/jclouds/glesys/features/ArchiveAsyncApi.java (121)
M providers/glesys/src/main/java/org/jclouds/glesys/features/DomainApi.java (78)
D providers/glesys/src/main/java/org/jclouds/glesys/features/DomainAsyncApi.java (146)
M providers/glesys/src/main/java/org/jclouds/glesys/features/EmailAccountApi.java (70)
D providers/glesys/src/main/java/org/jclouds/glesys/features/EmailAccountAsyncApi.java (135)
M providers/glesys/src/main/java/org/jclouds/glesys/features/IpApi.java (95)
D providers/glesys/src/main/java/org/jclouds/glesys/features/IpAsyncApi.java (162)
M providers/glesys/src/main/java/org/jclouds/glesys/features/ServerApi.java (173)
D providers/glesys/src/main/java/org/jclouds/glesys/features/ServerAsyncApi.java (262)
R providers/glesys/src/test/java/org/jclouds/glesys/GleSYSApiTest.java (15)
M providers/glesys/src/test/java/org/jclouds/glesys/features/ArchiveApiExpectTest.java (2)
M providers/glesys/src/test/java/org/jclouds/glesys/features/DomainApiExpectTest.java (2)
M providers/glesys/src/test/java/org/jclouds/glesys/features/ServerApiExpectTest.java (4)
-- Patch Links --
https://github.com/jclouds/jclouds/pull/88.patch
https://github.com/jclouds/jclouds/pull/88.diff
Re: [jclouds] Remove async from glesys (#88)
Posted by Andrew Bayer <no...@github.com>.
Pushed to master.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/88#issuecomment-22011185
Re: [jclouds] Remove async from glesys (#88)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests #95](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/95/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/88#issuecomment-21966917
Re: [jclouds] Remove async from glesys (#88)
Posted by Andrew Phillips <no...@github.com>.
> @@ -190,8 +303,12 @@ ServerDetails createWithHostnameAndRootPassword(ServerSpec serverSpec, String ho
> * @param resource the name of the resource to retrieve usage information for (e.g. "cpuusage")
> * @param resolution the time-period to extract data for (one of "minute", "hour" or "day)
> */
> - @Beta
> - // TODO: better name
> - ResourceUsage getResourceUsage(String id, String resource, String resolution);
> + @Named("server:resourceusage")
> + @POST
> + @Path("/server/resourceusage/format/json")
> + @SelectJson("usage")
> + @Consumes(MediaType.APPLICATION_JSON)
> + ResourceUsage getResourceUsage(@FormParam("serverid") String id, @FormParam("resource") String resource,
No longer in `@Beta`?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/88/files#r5557541
Re: [jclouds] Remove async from glesys (#88)
Posted by BuildHive <no...@github.com>.
[jclouds ยป jclouds #261](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/261/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/88#issuecomment-21968924
Re: [jclouds] Remove async from glesys (#88)
Posted by Andrew Phillips <no...@github.com>.
> * @param options optional parameters
> * @return information about the added domain
> */
> - Domain create(String domain, AddDomainOptions... options);
> + @Named("domain:add")
> + @POST
> + @Path("/domain/add/format/json")
> + @SelectJson("domain")
> + @Consumes(MediaType.APPLICATION_JSON)
> + Domain create(@FormParam("domainname") String name, AddDomainOptions... options);
See comment about `AddRecordOptions` below. I see that `update` below takes a **single** options object?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/88/files#r5557588
Re: [jclouds] Remove async from glesys (#88)
Posted by Andrew Phillips <no...@github.com>.
A couple of non-blocking comments about `options` args, but they're not really related to this PR. +1
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/88#issuecomment-22019995
Re: [jclouds] Remove async from glesys (#88)
Posted by Andrew Phillips <no...@github.com>.
> @@ -88,7 +131,14 @@
> * @param domain the domain to add the record to
> * @param options optional settings for the record
> */
> - DomainRecord createRecord(String domain, String host, String type, String data, AddRecordOptions... options);
> + @Named("domain:addrecord")
> + @POST
> + @Path("/domain/addrecord/format/json")
> + @SelectJson("record")
> + @Consumes(MediaType.APPLICATION_JSON)
> + DomainRecord createRecord(@FormParam("domainname") String domain, @FormParam("host") String host,
> + @FormParam("type") String type, @FormParam("data") String data,
> + AddRecordOptions... options);
The last open really is an **array** of `AddRecordOptions` objects, rather than just a single one?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/88/files#r5557571
Re: [jclouds] Remove async from glesys (#88)
Posted by Andrew Bayer <no...@github.com>.
Closed #88.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/88
Re: [jclouds] Remove async from glesys (#88)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-java-7-pull-requests #550](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/550/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/88#issuecomment-21966894
Re: [jclouds] Remove async from glesys (#88)
Posted by Andrew Phillips <no...@github.com>.
> *
> * @author Adrian Cole
> * @author Adam Lowe
> */
> -@Test(groups = "unit", testName = "ServerAsyncApiTest")
> +@Test(groups = "unit", testName = "ServerApiTest")
`ServerApiExpectTest`?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/88/files#r5557530