[GitHub] [dubbo-go] AlexStocks commented on a change in pull request #730: chore: Remove unnecessary return and judgement.

[GitBox <gi...@apache.org>]

AlexStocks commented on a change in pull request #730:
URL: https://github.com/apache/dubbo-go/pull/730#discussion_r478585105



##########
File path: common/rpc_service.go
##########
@@ -24,14 +24,9 @@ import (
 	"sync"
 	"unicode"
 	"unicode/utf8"
-)
 
-import (
-	perrors "github.com/pkg/errors"
-)
-
-import (
 	"github.com/apache/dubbo-go/common/logger"
+	perrors "github.com/pkg/errors"

Review comment:
       hey, guy, pls do not change our import code format. recover it pls.

##########
File path: config/base_config.go
##########
@@ -22,15 +22,10 @@ import (
 	"reflect"
 	"strconv"
 	"strings"
-)
-
-import (
-	perrors "github.com/pkg/errors"
-)
 
-import (
 	"github.com/apache/dubbo-go/common/config"
 	"github.com/apache/dubbo-go/common/logger"
+	perrors "github.com/pkg/errors"

Review comment:
       recover it pls.

##########
File path: config/reference_config.go
##########
@@ -23,20 +23,16 @@ import (
 	"net/url"
 	"strconv"
 	"time"
-)
 
-import (
 	"github.com/creasty/defaults"
-	gxstrings "github.com/dubbogo/gost/strings"
-)
 
-import (
 	"github.com/apache/dubbo-go/cluster/directory"
 	"github.com/apache/dubbo-go/common"
 	"github.com/apache/dubbo-go/common/constant"
 	"github.com/apache/dubbo-go/common/extension"
 	"github.com/apache/dubbo-go/common/proxy"
 	"github.com/apache/dubbo-go/protocol"
+	gxstrings "github.com/dubbogo/gost/strings"

Review comment:
       recove it.

##########
File path: registry/protocol/protocol.go
##########
@@ -21,23 +21,21 @@ import (
 	"context"
 	"strings"
 	"sync"
-)
-import (
-	gxset "github.com/dubbogo/gost/container/set"
-)
 
-import (
 	"github.com/apache/dubbo-go/common"
 	"github.com/apache/dubbo-go/common/constant"
 	"github.com/apache/dubbo-go/common/extension"
 	"github.com/apache/dubbo-go/common/logger"
 	"github.com/apache/dubbo-go/common/proxy/proxy_factory"
 	"github.com/apache/dubbo-go/config"
 	"github.com/apache/dubbo-go/config_center"
+	gxset "github.com/dubbogo/gost/container/set"

Review comment:
       recover it.

##########
File path: remoting/zookeeper/curator_discovery/service_discovery.go
##########
@@ -22,18 +22,14 @@ import (
 	"path"
 	"strings"
 	"sync"
-)
 
-import (
 	"github.com/dubbogo/go-zookeeper/zk"
-	perrors "github.com/pkg/errors"
-)
 
-import (
 	"github.com/apache/dubbo-go/common/constant"
 	"github.com/apache/dubbo-go/common/logger"
 	"github.com/apache/dubbo-go/remoting"
 	"github.com/apache/dubbo-go/remoting/zookeeper"
+	perrors "github.com/pkg/errors"

Review comment:
       recover it.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org