You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@polygene.apache.org by Paul Merlin <pa...@apache.org> on 2017/02/26 16:27:18 UTC
Re: [2/3] polygene-java git commit: Updated the devstatus for the
Cassandra ES.
Le 2017-02-26 15:22, niclas@apache.org a �crit�:
> Updated the devstatus for the Cassandra ES.
>
> <!-- none, brief, good, complete -->
> - <documentation>none</documentation>
> + <documentation>good</documentation>
>
> <!-- none, some, good, complete -->
> - <unittests>none</unittests>
> + <unittests>good</unittests>
Now that we have the infrastructure to do integration testing, we should
not flag tests as 'good' when they are not run by the test suite.
We need a docker based test of the new Cassandra ES.
Here are the steps involved:
- declare which docker image to use in ~/dependencies.gradle (at the
bottom of the file)
- add
internals/testsupport-internal/src/main/docker/cassandra/Dockerfile (see
the other Dockerfiles for inspiration)
- depend on polygene.internals.testsupport instead of
polygene.core.testsupport, this provides our JUnit DockerRule
- add the DockerRule and host/port settings to the test (see other
docker based tests for inspiration)
I'm pushing this also for me not to be the only one knowing how to do
this :)
Cheers
/Paul
Re: [2/3] polygene-java git commit: Updated the devstatus for the
Cassandra ES.
Posted by Niclas Hedhman <ni...@hedhman.org>.
Ok, good to know for next time.
On Mon, Feb 27, 2017 at 7:22 AM, Paul Merlin <pa...@apache.org> wrote:
> Le 2017-02-27 00:07, Niclas Hedhman a écrit :
>
>> I thought all needed was good, and the thing I didn't get right was the
>> @ClassRule, but otherwise I think it is good to go. Or?
>>
>
> After your change https://github.com/apache/polygene-java/commit/36cef00a,
> adding the DockerRule junit @ClassRule, the cassandra image is run in a
> docker container around tests.
>
> But the Cassandra ES was still trying the default host and port, failing
> here because I'm not running it locally. The only thing missing was to get
> the host and port allocated to the docker service and set them to the
> Cassandra ES config: https://github.com/apache/poly
> gene-java/commit/30c5ff23
>
>
>
--
Niclas Hedhman, Software Developer
http://polygene.apache.org <http://zest.apache.org> - New Energy for Java
Re: [2/3] polygene-java git commit: Updated the devstatus for the
Cassandra ES.
Posted by Paul Merlin <pa...@apache.org>.
Le 2017-02-27 00:07, Niclas Hedhman a �crit�:
> I thought all needed was good, and the thing I didn't get right was the
> @ClassRule, but otherwise I think it is good to go. Or?
After your change
https://github.com/apache/polygene-java/commit/36cef00a, adding the
DockerRule junit @ClassRule, the cassandra image is run in a docker
container around tests.
But the Cassandra ES was still trying the default host and port, failing
here because I'm not running it locally. The only thing missing was to
get the host and port allocated to the docker service and set them to
the Cassandra ES config:
https://github.com/apache/polygene-java/commit/30c5ff23
Re: [2/3] polygene-java git commit: Updated the devstatus for the
Cassandra ES.
Posted by Niclas Hedhman <ni...@hedhman.org>.
I thought all needed was good, and the thing I didn't get right was the
@ClassRule, but otherwise I think it is good to go. Or?
On Mon, Feb 27, 2017 at 12:27 AM, Paul Merlin <pa...@apache.org> wrote:
> Le 2017-02-26 15:22, niclas@apache.org a écrit :
>
>> Updated the devstatus for the Cassandra ES.
>>
>> <!-- none, brief, good, complete -->
>> - <documentation>none</documentation>
>> + <documentation>good</documentation>
>>
>> <!-- none, some, good, complete -->
>> - <unittests>none</unittests>
>> + <unittests>good</unittests>
>>
>
> Now that we have the infrastructure to do integration testing, we should
> not flag tests as 'good' when they are not run by the test suite.
> We need a docker based test of the new Cassandra ES.
>
> Here are the steps involved:
> - declare which docker image to use in ~/dependencies.gradle (at the
> bottom of the file)
> - add internals/testsupport-internal/src/main/docker/cassandra/Dockerfile
> (see the other Dockerfiles for inspiration)
> - depend on polygene.internals.testsupport instead of
> polygene.core.testsupport, this provides our JUnit DockerRule
> - add the DockerRule and host/port settings to the test (see other docker
> based tests for inspiration)
>
> I'm pushing this also for me not to be the only one knowing how to do this
> :)
>
> Cheers
>
> /Paul
>
>
--
Niclas Hedhman, Software Developer
http://polygene.apache.org <http://zest.apache.org> - New Energy for Java