[GitHub] merlimat commented on a change in pull request #3365: create_topic_with_check_namespaces_cluster

[GitBox <gi...@apache.org>]

merlimat commented on a change in pull request #3365: create_topic_with_check_namespaces_cluster
URL: https://github.com/apache/pulsar/pull/3365#discussion_r248559421
 
 

 ##########
 File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/AdminResource.java
 ##########
 @@ -234,6 +234,14 @@ protected void validateNamespaceName(String property, String namespace) {
         }
     }
 
+    protected void validateGlobalNamespaceOwnership(String property, String namespace) {
+        try {
+            this.namespaceName = NamespaceName.get(property, namespace);
+            validateGlobalNamespaceOwnership(this.namespaceName);
+        } catch (RestException re) {
 
 Review comment:
   One of the reason we handle the RestException separately is that we want to catch before the `catch(Exception)` block which will apply the generic error code instead of the more accurate error.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services