You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by da...@apache.org on 2019/06/24 09:16:16 UTC
[camel] 02/03: Type converter source code generator should include
javadoc about its source code generated by Camel. Optimise a bit to use
static method.
This is an automated email from the ASF dual-hosted git repository.
davsclaus pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/camel.git
commit 950d71f491886ddd8a370464bd986583642f957b
Author: Claus Ibsen <cl...@gmail.com>
AuthorDate: Mon Jun 24 10:49:09 2019 +0200
Type converter source code generator should include javadoc about its source code generated by Camel. Optimise a bit to use static method.
---
.../apache/camel/tools/apt/AbstractTypeConverterGenerator.java | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/tooling/apt/src/main/java/org/apache/camel/tools/apt/AbstractTypeConverterGenerator.java b/tooling/apt/src/main/java/org/apache/camel/tools/apt/AbstractTypeConverterGenerator.java
index d4941ab..a9f16ac 100644
--- a/tooling/apt/src/main/java/org/apache/camel/tools/apt/AbstractTypeConverterGenerator.java
+++ b/tooling/apt/src/main/java/org/apache/camel/tools/apt/AbstractTypeConverterGenerator.java
@@ -219,8 +219,11 @@ public abstract class AbstractTypeConverterGenerator extends AbstractCamelAnnota
writer.append("import org.apache.camel.support.TypeConverterSupport;\n");
writer.append("import org.apache.camel.util.DoubleMap;\n");
writer.append("\n");
+ writer.append("/**\n");
+ writer.append(" * Source code generated by org.apache.camel:apt\n");
+ writer.append(" */\n");
writer.append("@SuppressWarnings(\"unchecked\")\n");
- writer.append("public class ").append(c).append(" implements TypeConverterLoader {\n");
+ writer.append("public final class ").append(c).append(" implements TypeConverterLoader {\n");
writer.append("\n");
writer.append(" ").append("public ").append(c).append("() {\n");
writer.append(" }\n");
@@ -258,7 +261,7 @@ public abstract class AbstractTypeConverterGenerator extends AbstractCamelAnnota
writer.append("\n");
writer.append(
- " private void addTypeConverter(TypeConverterRegistry registry, Class<?> toType, Class<?> fromType, boolean allowNull, SimpleTypeConverter.ConversionMethod method)"
+ " private static void addTypeConverter(TypeConverterRegistry registry, Class<?> toType, Class<?> fromType, boolean allowNull, SimpleTypeConverter.ConversionMethod method)"
+ " { \n");
writer.append(" registry.addTypeConverter(toType, fromType, new SimpleTypeConverter(allowNull, method));\n");
writer.append(" }\n");
@@ -280,7 +283,7 @@ public abstract class AbstractTypeConverterGenerator extends AbstractCamelAnnota
writer.append(" }\n");
writer.append("\n");
- writer.append(" private void addFallbackTypeConverter(TypeConverterRegistry registry, boolean allowNull, boolean canPromote, SimpleTypeConverter.ConversionMethod method) { \n");
+ writer.append(" private static void addFallbackTypeConverter(TypeConverterRegistry registry, boolean allowNull, boolean canPromote, SimpleTypeConverter.ConversionMethod method) { \n");
writer.append(" registry.addFallbackTypeConverter(new SimpleTypeConverter(allowNull, method), canPromote);\n");
writer.append(" }\n");
writer.append("\n");