svn commit: r1435306 - /hbase/branches/0.89-fb/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java

[li...@apache.org]

Author: liyin
Date: Fri Jan 18 19:19:25 2013
New Revision: 1435306

URL: http://svn.apache.org/viewvc?rev=1435306&view=rev
Log:
[89-fb] [HBASE-7509] Initialize the number of threads for quorum reads after initializing fs

Author: aaiyer

Summary:
It looks like quorum reads are disabled on start up; irrespective of the
setting because the call was made before initializing the file system.
Ensure the correct order, so the configuration setting is respected.

Test Plan:
deploy to dev cluster and restart. Ensure that quorum reads
are enabled

Reviewers: liyintang

Reviewed By: liyintang

CC: hbase-eng@

Differential Revision: https://phabricator.fb.com/D678660

Modified:
    hbase/branches/0.89-fb/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java

Modified: hbase/branches/0.89-fb/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
URL: http://svn.apache.org/viewvc/hbase/branches/0.89-fb/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java?rev=1435306&r1=1435305&r2=1435306&view=diff
==============================================================================
--- hbase/branches/0.89-fb/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java (original)
+++ hbase/branches/0.89-fb/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java Fri Jan 18 19:19:25 2013
@@ -453,10 +453,6 @@ public class HRegionServer implements HR
               }
             });
 
-    int parallelHDFSReadPoolSize = conf.getInt(HConstants.HDFS_QUORUM_READ_THREADS_MAX,
-            HConstants.DEFAULT_HDFS_QUORUM_READ_THREADS_MAX);
-    LOG.debug("parallelHDFSReadPoolSize is (for quorum)" + parallelHDFSReadPoolSize);
-    this.setNumHDFSQuorumReadThreads(parallelHDFSReadPoolSize);
   }
 
   /**
@@ -1018,6 +1014,13 @@ public class HRegionServer implements HR
       }
       // Initialize the HLogs
       setupHLog(logdir, oldLogDir, this.hlogRollers.length);
+
+      // Set num of HDFS threads after this.fs is initialized.
+      int parallelHDFSReadPoolSize = conf.getInt(
+              HConstants.HDFS_QUORUM_READ_THREADS_MAX,
+              HConstants.DEFAULT_HDFS_QUORUM_READ_THREADS_MAX);
+      LOG.debug("parallelHDFSReadPoolSize is (for quorum)" + parallelHDFSReadPoolSize);
+      this.setNumHDFSQuorumReadThreads(parallelHDFSReadPoolSize);
       
       // Init in here rather than in constructor after thread name has been set
       this.metrics = new RegionServerMetrics();