You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2022/08/30 13:09:15 UTC

[GitHub] [skywalking] pg-yang opened a new issue, #9540: [Feature] Remove inappropriate dependency from elasticsearch-7.x-plugin

pg-yang opened a new issue, #9540:
URL: https://github.com/apache/skywalking/issues/9540

   ### Search before asking
   
   - [X] I had searched in the [issues](https://github.com/apache/skywalking/issues?q=is%3Aissue) and found no similar feature requirement.
   
   
   ### Description
   
   First , every  plugin  should  be  independent  . Right  ?
   `elasticsearch-7.x-plugin` depend  on ` elasticsearch-6.x-plugin` , it reference  some constant  , config class  from 6.x .
   So,   we should  remove  the dependency  .  I want  to  copy these  constant , config class from 6.x  rather  than  create  a common  module , Because the code is little  .
   
   
   https://github.com/apache/skywalking-java/blob/92665b8add7020f26f67519a6e6c7fef49e42643/apm-sniffer/apm-sdk-plugin/elasticsearch-7.x-plugin/pom.xml#L45
   
   ### Use case
   
   _No response_
   
   ### Related issues
   
   _No response_
   
   ### Are you willing to submit a PR?
   
   - [X] Yes I am willing to submit a PR!
   
   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wu-sheng commented on issue #9540: [Feature] Remove inappropriate dependency from elasticsearch-7.x-plugin

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #9540:
URL: https://github.com/apache/skywalking/issues/9540#issuecomment-1231670125

   Ideally, yes, we shoud keep them independent, unless they share some commons package.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wu-sheng closed issue #9540: [Feature] Remove inappropriate dependency from elasticsearch-7.x-plugin

Posted by GitBox <gi...@apache.org>.
wu-sheng closed issue #9540: [Feature] Remove  inappropriate dependency  from  elasticsearch-7.x-plugin 
URL: https://github.com/apache/skywalking/issues/9540


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wu-sheng commented on issue #9540: [Feature] Remove inappropriate dependency from elasticsearch-7.x-plugin

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #9540:
URL: https://github.com/apache/skywalking/issues/9540#issuecomment-1232292719

   Are you going to submit this soon? I plan to release 8.12.0 recently.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] pg-yang commented on issue #9540: [Feature] Remove inappropriate dependency from elasticsearch-7.x-plugin

Posted by GitBox <gi...@apache.org>.
pg-yang commented on issue #9540:
URL: https://github.com/apache/skywalking/issues/9540#issuecomment-1232319682

   no problem , tonight at the latest


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org