You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by JoshRosen <gi...@git.apache.org> on 2014/10/24 00:51:46 UTC
[GitHub] spark pull request: [SPARK-4070] [WIP] Add WebUITableBuilder to si...
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/2852#discussion_r19313715
--- Diff: core/src/main/scala/org/apache/spark/deploy/history/HistoryPage.scala ---
@@ -21,12 +21,28 @@ import javax.servlet.http.HttpServletRequest
import scala.xml.Node
-import org.apache.spark.ui.{WebUIPage, UIUtils}
+import org.apache.spark.ui.{UITableBuilder, UITable, WebUIPage, UIUtils}
private[spark] class HistoryPage(parent: HistoryServer) extends WebUIPage("") {
private val pageSize = 20
+ val appTable: UITable[ApplicationHistoryInfo] = {
+ val builder = new UITableBuilder[ApplicationHistoryInfo]()
+ import builder._
+ customCol("App ID") { info =>
+ val uiAddress = HistoryServer.UI_PATH_PREFIX + s"/${info.id}"
+ <a href={uiAddress}>{info.id}</a>
+ }
+ col("App Name") { _.name }
--- End diff --
Do you think that the Javadoc comment at the top of UITableBuilder mitigates this confusion?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org