You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kyuubi.apache.org by GitBox <gi...@apache.org> on 2022/01/27 11:25:35 UTC
[GitHub] [incubator-kyuubi] pan3793 opened a new pull request #1849: Bump Iceberg 0.13.0 and enable Iceberg test with Spark 3.2
pan3793 opened a new pull request #1849:
URL: https://github.com/apache/incubator-kyuubi/pull/1849
### _Why are the changes needed?_
Bump Iceberg 0.13.0 and enable Iceberg test with Spark 3.2.
Testing with Iceberg 0.13.0 RC1
Note: https://www.mail-archive.com/dev@iceberg.apache.org/msg03206.html
### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
- [ ] Add screenshots for manual tests if appropriate
- [x] [Run test](https://kyuubi.apache.org/docs/latest/develop_tools/testing.html#running-tests) locally before make a pull request
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on pull request #1849: Bump Iceberg 0.13.0 and enable Iceberg test with Spark 3.2
Posted by GitBox <gi...@apache.org>.
pan3793 commented on pull request #1849:
URL: https://github.com/apache/incubator-kyuubi/pull/1849#issuecomment-1029709163
Merging to master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] pan3793 closed pull request #1849: Bump Iceberg 0.13.0 and enable Iceberg test with Spark 3.2
Posted by GitBox <gi...@apache.org>.
pan3793 closed pull request #1849:
URL: https://github.com/apache/incubator-kyuubi/pull/1849
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] codecov-commenter commented on pull request #1849: Bump Iceberg 0.13.0 and enable Iceberg test with Spark 3.2
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #1849:
URL: https://github.com/apache/incubator-kyuubi/pull/1849#issuecomment-1027260434
# [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1849?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1849](https://codecov.io/gh/apache/incubator-kyuubi/pull/1849?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (39b156b) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/b2bad04d75e2a6cc73039506441af8405f93a8a3?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b2bad04) will **increase** coverage by `0.00%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-kyuubi/pull/1849?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1849 +/- ##
=========================================
Coverage 59.70% 59.70%
- Complexity 267 269 +2
=========================================
Files 282 282
Lines 13978 13978
Branches 1781 1781
=========================================
+ Hits 8345 8346 +1
Misses 4924 4924
+ Partials 709 708 -1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/1849?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...rg/apache/kyuubi/engine/trino/TrinoStatement.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1849/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS10cmluby1lbmdpbmUvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9reXV1YmkvZW5naW5lL3RyaW5vL1RyaW5vU3RhdGVtZW50LnNjYWxh) | `65.88% <0.00%> (+1.17%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1849?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1849?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [b2bad04...39b156b](https://codecov.io/gh/apache/incubator-kyuubi/pull/1849?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on a change in pull request #1849: Bump Iceberg 0.13.0 and enable Iceberg test with Spark 3.2
Posted by GitBox <gi...@apache.org>.
pan3793 commented on a change in pull request #1849:
URL: https://github.com/apache/incubator-kyuubi/pull/1849#discussion_r796938144
##########
File path: kyuubi-common/src/test/scala/org/apache/kyuubi/IcebergSuiteMixin.scala
##########
@@ -42,5 +42,7 @@ trait IcebergSuiteMixin extends DataLakeSuiteMixin {
s"spark.sql.catalog.$catalog" -> "org.apache.iceberg.spark.SparkCatalog",
s"spark.sql.catalog.$catalog.type" -> "hadoop",
s"spark.sql.catalog.$catalog.warehouse" -> warehouse.toString,
+ // TODO maybe an issue of iceberg 0.13.0
+ s"spark.sql.catalog.$catalog.default-namespace" -> "default",
Review comment:
we need this because of https://github.com/apache/iceberg/pull/4024
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org