[GitHub] [linkis] legendtkl commented on a diff in pull request #4427: [Feature] Change KIND to an optional way on kubernetes deployment

["legendtkl (via GitHub)" <gi...@apache.org>]

legendtkl commented on code in PR #4427:
URL: https://github.com/apache/linkis/pull/4427#discussion_r1154339362


##########
linkis-dist/helm/scripts/install-mysql.sh:
##########
@@ -24,7 +24,7 @@ MYSQL_VERSION=${MYSQL_VERSION:-5.7}
 set -e
 
 # load image
-if [ "X${KIND_LOAD_IMAGE}" == "Xtrue" ]; then
+if [ "X${USING}" == "Xtrue" ]; then

Review Comment:
   "USING" here seems to be a typo?



##########
linkis-dist/helm/scripts/install-linkis.sh:
##########
@@ -21,9 +21,8 @@ WORK_DIR=`cd $(dirname $0); pwd -P`
 
 KUBE_NAMESPACE=${1:-linkis}
 HELM_RELEASE_NAME=${2:-linkis-demo}
-LOCAL_MODE=${3:-true}
-
-. ${WORK_DIR}/common.sh
+USING_KIND=${3:-false}
+LOCAL_MODE=${4:-true}

Review Comment:
   What about keep LOCAL_MODE as the same, like
   
   ```shell
   LOCAL_MODE=${3:-true}
   USING_KIND=${4:-false}
   ```



##########
linkis-dist/helm/scripts/install-linkis.sh:
##########
@@ -21,9 +21,8 @@ WORK_DIR=`cd $(dirname $0); pwd -P`
 
 KUBE_NAMESPACE=${1:-linkis}
 HELM_RELEASE_NAME=${2:-linkis-demo}
-LOCAL_MODE=${3:-true}
-
-. ${WORK_DIR}/common.sh

Review Comment:
   Deleting the shell `common.sh` scripts invoke is expected?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For additional commands, e-mail: notifications-help@linkis.apache.org