[GitHub] rnewson commented on a change in pull request #1176: Implement pluggable authentication and session support for replicator

[GitBox <gi...@apache.org>]

rnewson commented on a change in pull request #1176: Implement pluggable authentication and session support for replicator
URL: https://github.com/apache/couchdb/pull/1176#discussion_r170064207
 
 

 ##########
 File path: src/couch_replicator/include/couch_replicator_api_wrap.hrl
 ##########
 @@ -26,13 +26,6 @@
     httpc_pool = nil,
     http_connections,
     first_error_timestamp = nil,
-    proxy_url
-}).
-
--record(oauth, {
-    consumer_key,
-    token,
-    token_secret,
-    consumer_secret,
-    signature_method
+    proxy_url,
+    auth_context = nil
 
 Review comment:
   before I go deeper, we're changing the default for one field and adding an extra property. Are we sure there's no upgrade problem here? I think we never pass httpdb's between nodes but this would be bad if we did.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services