You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "codecov[bot] (via GitHub)" <gi...@apache.org> on 2023/06/22 21:54:54 UTC
[GitHub] [superset] codecov[bot] commented on pull request #24488: chore(dao): Add explicit ON DELETE CASCADE when deleting datasets
codecov[bot] commented on PR #24488:
URL: https://github.com/apache/superset/pull/24488#issuecomment-1603363482
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/24488?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#24488](https://app.codecov.io/gh/apache/superset/pull/24488?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (ebfa61c) into [master](https://app.codecov.io/gh/apache/superset/commit/2a4ef5cccf3d3f8f2f7ccfc8c590f8f2fde31ab0?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (2a4ef5c) will **decrease** coverage by `11.00%`.
> The diff coverage is `50.00%`.
> :exclamation: Current head ebfa61c differs from pull request most recent head 81224e0. Consider uploading reports for the commit 81224e0 to get more accurate results
```diff
@@ Coverage Diff @@
## master #24488 +/- ##
===========================================
- Coverage 69.03% 58.03% -11.00%
===========================================
Files 1901 1901
Lines 74006 73994 -12
Branches 8115 8115
===========================================
- Hits 51088 42942 -8146
- Misses 20807 28941 +8134
Partials 2111 2111
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| mysql | `?` | |
| postgres | `?` | |
| presto | `53.80% <50.00%> (+0.01%)` | :arrow_up: |
| python | `60.61% <50.00%> (-22.88%)` | :arrow_down: |
| sqlite | `?` | |
| unit | `54.67% <50.00%> (+0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://app.codecov.io/gh/apache/superset/pull/24488?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [superset/daos/dataset.py](https://app.codecov.io/gh/apache/superset/pull/24488?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvZGFvcy9kYXRhc2V0LnB5) | `50.38% <ø> (-40.86%)` | :arrow_down: |
| [superset/datasets/commands/delete.py](https://app.codecov.io/gh/apache/superset/pull/24488?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvZGVsZXRlLnB5) | `48.38% <25.00%> (-48.92%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://app.codecov.io/gh/apache/superset/pull/24488?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `74.85% <100.00%> (-16.53%)` | :arrow_down: |
... and [298 files with indirect coverage changes](https://app.codecov.io/gh/apache/superset/pull/24488/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org