[jira] Commented: (WICKET-1917) Automatically Load CSS files based on name matching

["Martin Benda (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/WICKET-1917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12665945#action_12665945 ] 

Martin Benda commented on WICKET-1917:
--------------------------------------

Hi!

This "improvement" can - in some cases - save a few lines of code but it has a major impact on overall wicket performance! IMHO, this kind of "black" magic should not be hard-coded in the framework core...

Please see http://www.nabble.com/WICKET-1970%3A-a-major-performance-issue-td21581059.html for details and revert the patch back.

Regards,
Bendis

> Automatically Load CSS files based on name matching
> ---------------------------------------------------
>
>                 Key: WICKET-1917
>                 URL: https://issues.apache.org/jira/browse/WICKET-1917
>             Project: Wicket
>          Issue Type: New Feature
>          Components: wicket
>            Reporter: Christopher J Lyth
>            Assignee: Juergen Donnerstag
>            Priority: Minor
>             Fix For: 1.4-RC2
>
>
> I often find myself adding CSS files to wicket with the same name as my pages (i.e. BasePage.css). I then have to add the reference through an html link or a header contributer. I would like to load these automatically in a similar manor as the properties files. 
> I feel this should be expanded to include the ability to skin the application in the following manor.
> BasePage.css
> BasePage_chrome.css
> BasePage_metal.css
> I would also recommend setting this in a similar manor to other patterns in wicket. It would use the closest name match by default (i.e. BasePage.css). I imagine this could also be set by system property (wicket.skin) or programatically. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.