[GitHub] [incubator-iceberg] jerryshao commented on a change in pull request #421: Add friendly names to catalog tables

[GitBox <gi...@apache.org>]

jerryshao commented on a change in pull request #421: Add friendly names to catalog tables
URL: https://github.com/apache/incubator-iceberg/pull/421#discussion_r347259234
 
 

 ##########
 File path: hive/src/main/java/org/apache/iceberg/hive/HiveCatalog.java
 ##########
 @@ -43,6 +43,11 @@ public HiveCatalog(Configuration conf) {
     this.conf = conf;
   }
 
+  @Override
+  protected String name() {
+    return conf.get("hive.metastore.uris");
 
 Review comment:
   I agree with @rdsr , using metastore uri seems a bit strange, maybe we could use conf to specify one. For example if it adapts to Spark DSv2 catalog interface, it could leverage Spark to pass in a catalog name.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org