You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2020/08/26 00:46:16 UTC

[GitHub] [hudi] yanghua commented on pull request #2032: [HUDI-1223] Remove unused UpdateHandler class in HoodieCopyOnWriteTable

yanghua commented on pull request #2032:
URL: https://github.com/apache/hudi/pull/2032#issuecomment-680376811


   > ## _Tips_
   > * _Thank you very much for contributing to Apache Hudi._
   > * _Please review https://hudi.apache.org/contributing.html before opening a pull request._
   > 
   > ## What is the purpose of the pull request
   > _(For example: This pull request adds quick-start document.)_
   > 
   > ## Brief change log
   > _(for example:)_
   > 
   > * _Modify AnnotationLocation checkstyle rule in checkstyle.xml_
   > 
   > ## Verify this pull request
   > _(Please pick either of the following options)_
   > 
   > This pull request is a trivial rework / code cleanup without any test coverage.
   > 
   > _(or)_
   > 
   > This pull request is already covered by existing tests, such as _(please describe tests)_.
   > 
   > (or)
   > 
   > This change added tests and can be verified as follows:
   > 
   > _(example:)_
   > 
   > * _Added integration tests for end-to-end._
   > * _Added HoodieClientWriteTest to verify the change._
   > * _Manually verified the change by running a job locally._
   > 
   > ## Committer checklist
   > * [ ]  Has a corresponding JIRA in PR title & commit
   > * [ ]  Commit message is descriptive of the change
   > * [ ]  CI is green
   > * [ ]  Necessary doc changes done or have another open PR
   > * [ ]  For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
   
   IMO, it would be better to write correct description of each PR.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org