You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by ps...@apache.org on 2004/03/07 21:47:06 UTC
cvs commit: jakarta-commons/math/src/test/org/apache/commons/math/stat TestStatisticTest.java
psteitz 2004/03/07 12:47:06
Modified: math/src/test/org/apache/commons/math/stat
TestStatisticTest.java
Log:
Stopped swallowing MathExceptions, cleaned up formatting.
Revision Changes Path
1.12 +88 -266 jakarta-commons/math/src/test/org/apache/commons/math/stat/TestStatisticTest.java
Index: TestStatisticTest.java
===================================================================
RCS file: /home/cvs/jakarta-commons/math/src/test/org/apache/commons/math/stat/TestStatisticTest.java,v
retrieving revision 1.11
retrieving revision 1.12
diff -u -r1.11 -r1.12
--- TestStatisticTest.java 21 Feb 2004 21:35:17 -0000 1.11
+++ TestStatisticTest.java 7 Mar 2004 20:47:06 -0000 1.12
@@ -43,14 +43,10 @@
return suite;
}
- public void testChiSquare() {
+ public void testChiSquare() throws MathException {
double[] observed = { 11, 24, 69, 96 };
double[] expected = { 8.2, 25.2, 65.8, 100.8 };
- assertEquals(
- "chi-square statistic",
- 1.39743495,
- testStatistic.chiSquare(expected, observed),
- 10E-5);
+ assertEquals("chi-square statistic", 1.39743495, testStatistic.chiSquare(expected, observed), 10E-5);
double[] tooShortObs = { 0 };
double[] tooShortEx = { 1 };
@@ -58,156 +54,91 @@
testStatistic.chiSquare(tooShortObs, tooShortEx);
fail("arguments too short, IllegalArgumentException expected");
} catch (IllegalArgumentException ex) {
- ;
+ // expected
}
try {
testStatistic.chiSquareTest(tooShortObs, tooShortEx);
fail("arguments too short, IllegalArgumentException expected");
} catch (IllegalArgumentException ex) {
- ;
- } catch (MathException e) {
- // TODO Auto-generated catch block
- e.printStackTrace();
- }
+ // expected
+ }
double[] unMatchedObs = { 0, 1, 2, 3 };
double[] unMatchedEx = { 1, 1, 2 };
try {
testStatistic.chiSquare(unMatchedEx, unMatchedObs);
- fail(
- "arrays have different lengths,"
- + " IllegalArgumentException expected");
+ fail("arrays have different lengths, IllegalArgumentException expected");
} catch (IllegalArgumentException ex) {
- ;
+ // expected
}
expected[0] = 0;
try {
testStatistic.chiSquareTest(expected, observed, .01);
fail("bad expected count, IllegalArgumentException expected");
} catch (IllegalArgumentException ex) {
- ;
- } catch (MathException e) {
- // TODO Auto-generated catch block
- e.printStackTrace();
- }
+ // expected
+ }
+
/** from http://www.vsenvirginia.org/stat/classpractice/Voter_Preferences_CP.pdf */
double[] observed1 = { 504, 523, 72, 70, 31 };
double[] expected1 = { 480, 540, 84, 60, 36 };
-
- try {
- assertEquals(
- "chi-square test statistic",
- 5.81,
- testStatistic.chiSquare(expected1, observed1),
- 10E-2);
- assertEquals(
- "chi-square p-value",
- 0.21,
- testStatistic.chiSquareTest(expected1, observed1),
- 10E-2);
- assertTrue(
- "chi-square test reject",
- testStatistic.chiSquareTest(expected1, observed1, 0.3));
- assertTrue(
- "chi-square test accept",
- !testStatistic.chiSquareTest(expected1, observed1, 0.1));
-
- } catch (MathException e) {
- // TODO Auto-generated catch block
- e.printStackTrace();
- }
+ assertEquals( "chi-square test statistic", 5.81, testStatistic.chiSquare(expected1, observed1), 10E-2);
+ assertEquals("chi-square p-value", 0.21, testStatistic.chiSquareTest(expected1, observed1), 10E-2);
+ assertTrue("chi-square test reject", testStatistic.chiSquareTest(expected1, observed1, 0.3));
+ assertTrue("chi-square test accept", !testStatistic.chiSquareTest(expected1, observed1, 0.1));
try {
testStatistic.chiSquareTest(expected1, observed1, 95);
fail("alpha out of range, IllegalArgumentException expected");
} catch (IllegalArgumentException ex) {
- ;
- } catch (MathException e) {
- // TODO Auto-generated catch block
- e.printStackTrace();
+ // expected
}
}
- public void testT() {
+ public void testT() throws Exception {
double[] observed =
- {
- 93.0,
- 103.0,
- 95.0,
- 101.0,
- 91.0,
- 105.0,
- 96.0,
- 94.0,
- 101.0,
- 88.0,
- 98.0,
- 94.0,
- 101.0,
- 92.0,
- 95.0 };
+ {93.0, 103.0, 95.0, 101.0, 91.0, 105.0, 96.0, 94.0, 101.0, 88.0, 98.0, 94.0, 101.0, 92.0, 95.0 };
double mu = 100.0;
SummaryStatistics sampleStats = null;
- try {
- sampleStats =
- SummaryStatistics.newInstance(
- SummaryStatisticsImpl.class);
- } catch (InstantiationException e5) {
- // TODO Auto-generated catch block
- e5.printStackTrace();
- } catch (IllegalAccessException e5) {
- // TODO Auto-generated catch block
- e5.printStackTrace();
- }
+ sampleStats = SummaryStatistics.newInstance();
for (int i = 0; i < observed.length; i++) {
sampleStats.addValue(observed[i]);
}
- assertEquals(
- "t statistic",
- -2.82,
- testStatistic.t(mu, observed),
- 10E-3);
- assertEquals(
- "t statistic",
- -2.82,
- testStatistic.t(mu, sampleStats),
- 10E-3);
+ assertEquals("t statistic", -2.82, testStatistic.t(mu, observed), 10E-3);
+ assertEquals("t statistic", -2.82, testStatistic.t(mu, sampleStats), 10E-3);
double[] nullObserved = null;
try {
testStatistic.t(mu, nullObserved);
fail("arguments too short, IllegalArgumentException expected");
} catch (IllegalArgumentException ex) {
- ;
+ // expected
}
- SummaryStatistics nullStats = SummaryStatistics.newInstance();
-
+ SummaryStatistics nullStats = null;
try {
testStatistic.t(mu, nullStats);
fail("arguments too short, IllegalArgumentException expected");
} catch (IllegalArgumentException ex) {
- ;
+ // expected
}
- double[] emptyObs = {
- };
+ double[] emptyObs = {};
try {
testStatistic.t(mu, emptyObs);
fail("arguments too short, IllegalArgumentException expected");
} catch (IllegalArgumentException ex) {
- ;
+ // expected
}
- SummaryStatistics emptyStats =SummaryStatistics.newInstance();
-
+ SummaryStatistics emptyStats =SummaryStatistics.newInstance();
try {
testStatistic.t(mu, emptyStats);
fail("arguments too short, IllegalArgumentException expected");
} catch (IllegalArgumentException ex) {
- ;
+ // expected
}
double[] tooShortObs = { 1.0 };
@@ -215,248 +146,139 @@
testStatistic.t(mu, tooShortObs);
fail("arguments too short, IllegalArgumentException expected");
} catch (IllegalArgumentException ex) {
- ;
+ // exptected
}
try {
testStatistic.tTest(mu, tooShortObs);
fail("arguments too short, IllegalArgumentException expected");
} catch (IllegalArgumentException ex) {
- ;
- } catch (MathException e) {
- // TODO Auto-generated catch block
- e.printStackTrace();
- }
+ // expected
+ }
- SummaryStatistics tooShortStats = SummaryStatistics.newInstance();
-
+ SummaryStatistics tooShortStats = SummaryStatistics.newInstance();
tooShortStats.addValue(0d);
tooShortStats.addValue(2d);
try {
testStatistic.t(mu, tooShortStats);
fail("arguments too short, IllegalArgumentException expected");
} catch (IllegalArgumentException ex) {
- ;
+ // exptected
}
try {
testStatistic.tTest(mu, tooShortStats);
fail("arguments too short, IllegalArgumentException expected");
} catch (IllegalArgumentException ex) {
- ;
- } catch (MathException e) {
- // TODO Auto-generated catch block
- e.printStackTrace();
- }
+ // exptected
+ }
/** Moore and McCabe Example 8.3, p 516 */
double[] oneSidedP =
- {
- 2d,
- 0d,
- 6d,
- 6d,
- 3d,
- 3d,
- 2d,
- 3d,
- -6d,
- 6d,
- 6d,
- 6d,
- 3d,
- 0d,
- 1d,
- 1d,
- 0d,
- 2d,
- 3d,
- 3d };
-
- SummaryStatistics oneSidedPStats = SummaryStatistics.newInstance();;
-
+ {2d, 0d, 6d, 6d, 3d, 3d, 2d, 3d, -6d, 6d, 6d, 6d, 3d, 0d, 1d, 1d, 0d, 2d, 3d, 3d };
+ SummaryStatistics oneSidedPStats = SummaryStatistics.newInstance();
for (int i = 0; i < oneSidedP.length; i++) {
oneSidedPStats.addValue(oneSidedP[i]);
}
-
- try {
- assertEquals(
- "one sample t stat",
- 3.86,
- testStatistic.t(0d, oneSidedP),
- 0.01);
- assertEquals(
- "one sample t stat",
- 3.86,
- testStatistic.t(0d, oneSidedPStats),
- 0.01);
- assertEquals(
- "one sample p value",
- 0.00052,
- testStatistic.tTest(0d, oneSidedP) / 2d,
- 10E-5);
- assertEquals(
- "one sample p value",
- 0.00052,
- testStatistic.tTest(0d, oneSidedPStats) / 2d,
- 10E-5);
- assertTrue(
- "one sample t-test reject",
- testStatistic.tTest(0d, oneSidedP, 0.01));
- assertTrue(
- "one sample t-test reject",
- testStatistic.tTest(0d, oneSidedPStats, 0.01));
- assertTrue(
- "one sample t-test accept",
- !testStatistic.tTest(0d, oneSidedP, 0.0001));
- assertTrue(
- "one sample t-test accept",
- !testStatistic.tTest(0d, oneSidedPStats, 0.0001));
-
- } catch (MathException e) {
- // TODO Auto-generated catch block
- e.printStackTrace();
- }
-
+ assertEquals("one sample t stat", 3.86, testStatistic.t(0d, oneSidedP), 0.01);
+ assertEquals("one sample t stat", 3.86, testStatistic.t(0d, oneSidedPStats), 0.01);
+ assertEquals("one sample p value", 0.00052, testStatistic.tTest(0d, oneSidedP) / 2d, 10E-5);
+ assertEquals("one sample p value", 0.00052, testStatistic.tTest(0d, oneSidedPStats) / 2d, 10E-5);
+ assertTrue("one sample t-test reject", testStatistic.tTest(0d, oneSidedP, 0.01));
+ assertTrue("one sample t-test reject", testStatistic.tTest(0d, oneSidedPStats, 0.01));
+ assertTrue("one sample t-test accept", !testStatistic.tTest(0d, oneSidedP, 0.0001));
+ assertTrue("one sample t-test accept", !testStatistic.tTest(0d, oneSidedPStats, 0.0001));
+
try {
testStatistic.tTest(0d, oneSidedP, 95);
fail("alpha out of range, IllegalArgumentException expected");
} catch (IllegalArgumentException ex) {
- ;
- } catch (MathException e) {
- // TODO Auto-generated catch block
- e.printStackTrace();
- }
+ // exptected
+ }
+
try {
testStatistic.tTest(0d, oneSidedPStats, 95);
fail("alpha out of range, IllegalArgumentException expected");
} catch (IllegalArgumentException ex) {
- ;
- } catch (MathException e) {
- // TODO Auto-generated catch block
- e.printStackTrace();
- }
+ // expected
+ }
/** Moore and McCabe Example 8.12, p 552 */
double[] sample1 = { 7d, -4d, 18d, 17d, -3d, -5d, 1d, 10d, 11d, -2d };
- double[] sample2 =
- { -1d, 12d, -1d, -3d, 3d, -5d, 5d, 2d, -11d, -1d, -3d };
-
- SummaryStatistics sampleStats1 = SummaryStatistics.newInstance();
-
+ double[] sample2 = { -1d, 12d, -1d, -3d, 3d, -5d, 5d, 2d, -11d, -1d, -3d };
+ SummaryStatistics sampleStats1 = SummaryStatistics.newInstance();
for (int i = 0; i < sample1.length; i++) {
sampleStats1.addValue(sample1[i]);
}
-
- SummaryStatistics sampleStats2 = SummaryStatistics.newInstance();
-
+ SummaryStatistics sampleStats2 = SummaryStatistics.newInstance();
for (int i = 0; i < sample2.length; i++) {
sampleStats2.addValue(sample2[i]);
}
- try {
- //FIXME: textbook example reported t stat uses pooled variance
- // should replace with R-verified example
- assertEquals(
- "two sample t stat",
- 1.634,
- testStatistic.t(sample1, sample2),
- 0.1);
- assertEquals(
- "two sample t stat",
- 1.634,
- testStatistic.t(sampleStats1, sampleStats2),
- 0.1);
- // This test is OK, since book reports non-pooled exact p-value
- assertEquals(
- "two sample p value",
- 0.059,
- testStatistic.tTest(sample1, sample2) / 2d,
- 10E-3);
- assertEquals(
- "two sample p value",
- 0.059,
- testStatistic.tTest(sampleStats1, sampleStats2) / 2d,
- 10E-3);
- assertTrue(
- "two sample t-test reject",
- testStatistic.tTest(sample1, sample2, 0.2));
- assertTrue(
- "two sample t-test reject",
- testStatistic.tTest(sampleStats1, sampleStats2, 0.2));
- assertTrue(
- "two sample t-test accept",
- !testStatistic.tTest(sample1, sample2, 0.1));
- assertTrue(
- "two sample t-test accept",
- !testStatistic.tTest(sampleStats1, sampleStats2, 0.1));
-
- } catch (MathException e) {
- // TODO Auto-generated catch block
- e.printStackTrace();
- }
+ //FIXME: textbook example reported t stat uses pooled variance
+ // should replace the following two tests with R-verified example
+ assertEquals("two sample t stat", 1.634, testStatistic.t(sample1, sample2), 0.1);
+ assertEquals("two sample t stat", 1.634, testStatistic.t(sampleStats1, sampleStats2), 0.1);
+
+ // These tests are OK, since book reports non-pooled exact p-value
+ assertEquals("two sample p value", 0.059, testStatistic.tTest(sample1, sample2) / 2d, 10E-3);
+ assertEquals("two sample p value", 0.059, testStatistic.tTest(sampleStats1, sampleStats2) / 2d, 10E-3);
+ assertTrue("two sample t-test reject", testStatistic.tTest(sample1, sample2, 0.2));
+ assertTrue("two sample t-test reject", testStatistic.tTest(sampleStats1, sampleStats2, 0.2));
+ assertTrue("two sample t-test accept", !testStatistic.tTest(sample1, sample2, 0.1));
+ assertTrue("two sample t-test accept", !testStatistic.tTest(sampleStats1, sampleStats2, 0.1));
+
try {
testStatistic.tTest(sample1, sample2, 95);
fail("alpha out of range, IllegalArgumentException expected");
} catch (IllegalArgumentException ex) {
- ;
- } catch (MathException e) {
- // TODO Auto-generated catch block
- e.printStackTrace();
- }
+ // exptected
+ }
+
try {
testStatistic.tTest(sampleStats1, sampleStats2, 95);
fail("alpha out of range, IllegalArgumentException expected");
} catch (IllegalArgumentException ex) {
- ;
- } catch (MathException e) {
- // TODO Auto-generated catch block
- e.printStackTrace();
- }
+ // expected
+ }
+
try {
testStatistic.tTest(sample1, tooShortObs, .01);
fail("insufficient data, IllegalArgumentException expected");
} catch (IllegalArgumentException ex) {
- ;
- } catch (MathException e) {
- // TODO Auto-generated catch block
- e.printStackTrace();
- }
+ // expected
+ }
+
try {
testStatistic.tTest(sampleStats1, tooShortStats, .01);
fail("insufficient data, IllegalArgumentException expected");
} catch (IllegalArgumentException ex) {
- ;
- } catch (MathException e) {
- // TODO Auto-generated catch block
- e.printStackTrace();
- }
+ // expected
+ }
+
try {
testStatistic.tTest(sample1, tooShortObs);
fail("insufficient data, IllegalArgumentException expected");
} catch (IllegalArgumentException ex) {
- ;
- } catch (MathException e) {
- // TODO Auto-generated catch block
- e.printStackTrace();
- }
+ // expected
+ }
+
try {
testStatistic.tTest(sampleStats1, tooShortStats);
fail("insufficient data, IllegalArgumentException expected");
} catch (IllegalArgumentException ex) {
- ;
- } catch (MathException e) {
- // TODO Auto-generated catch block
- e.printStackTrace();
- }
+ // expected
+ }
+
try {
testStatistic.t(sample1, tooShortObs);
fail("insufficient data, IllegalArgumentException expected");
} catch (IllegalArgumentException ex) {
- ;
+ // expected
}
+
try {
testStatistic.t(sampleStats1, tooShortStats);
fail("insufficient data, IllegalArgumentException expected");
} catch (IllegalArgumentException ex) {
- ;
+ // exptected
}
}
}
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org