You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2021/06/28 21:50:22 UTC

[GitHub] [solr] thelabdude opened a new pull request #197: SOLR-15499: StatsStream implement ParallelMetricsRollup to allow for tiered computation for collection aliases

thelabdude opened a new pull request #197:
URL: https://github.com/apache/solr/pull/197


   
   https://issues.apache.org/jira/browse/SOLR-15499
   
   
   # Description
   
   See JIRA
   
   # Solution
   
   StatsStream implements ParallelMetricsRollup
   
   # Tests
   
   Needs more testing ...
   
   # Checklist
   
   Please review the following and check all that apply:
   
   - [ ] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability.
   - [ ] I have created a Jira issue and added the issue ID to my pull request title.
   - [ ] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended)
   - [ ] I have developed this patch against the `main` branch.
   - [ ] I have run `./gradlew check`.
   - [ ] I have added tests for my changes.
   - [ ] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org


[GitHub] [solr] thelabdude merged pull request #197: SOLR-15499: StatsStream implement ParallelMetricsRollup to allow for tiered computation for collection aliases

Posted by GitBox <gi...@apache.org>.
thelabdude merged pull request #197:
URL: https://github.com/apache/solr/pull/197


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org


[GitHub] [solr] markrmiller commented on a change in pull request #197: SOLR-15499: StatsStream implement ParallelMetricsRollup to allow for tiered computation for collection aliases

Posted by GitBox <gi...@apache.org>.
markrmiller commented on a change in pull request #197:
URL: https://github.com/apache/solr/pull/197#discussion_r663154203



##########
File path: solr/solrj/src/java/org/apache/solr/client/solrj/io/stream/StatsStream.java
##########
@@ -352,4 +378,31 @@ public int getCost() {
   public StreamComparator getStreamSort() {
     return null;
   }
+
+  @Override
+  public TupleStream[] parallelize(List<String> partitions) throws IOException {
+    final ModifiableSolrParams withoutTieredParam = new ModifiableSolrParams(params);
+    withoutTieredParam.remove(TIERED_PARAM); // each individual request is not tiered
+
+    TupleStream[] streams = new TupleStream[partitions.size()];
+    for (int p = 0; p < streams.length; p++) {
+      streams[p] = new StatsStream(zkHost, partitions.get(p), withoutTieredParam, metrics);
+    }
+    return streams;
+  }
+
+  @Override
+  public TupleStream getSortedRollupStream(ParallelListStream plist, Metric[] rollupMetrics) throws IOException {
+    return new SelectStream(new HashRollupStream(plist, STATS_BUCKET, rollupMetrics), getRollupSelectFields(rollupMetrics));
+  }
+
+  // Map the rollup metric to the original metric name so that we can project out the correct field names in the tuple
+  protected Map<String, String> getRollupSelectFields(Metric[] rollupMetrics) {
+    Map<String, String> map = new HashMap<>();

Review comment:
       set the initial size for this?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org