[jira] [Commented] (KYLIN-3483) Imprecise comparison between double and integer division

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KYLIN-3483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16569429#comment-16569429 ] 

ASF GitHub Bot commented on KYLIN-3483:
---------------------------------------

asfgit commented on issue #187: KYLIN-3483, fix the loss of precision in HLLCSerializer.
URL: https://github.com/apache/kylin/pull/187#issuecomment-410511344
 
 
   Can one of the admins verify this patch?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Imprecise comparison between double and integer division
> --------------------------------------------------------
>
>                 Key: KYLIN-3483
>                 URL: https://issues.apache.org/jira/browse/KYLIN-3483
>             Project: Kylin
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Assignee: jiatao.tao
>            Priority: Minor
>
> In HLLCSerializer :
> {code}
>                 || averageNumOfElementsInCounter < (m - 5) / (1 + registerIndexSize)) {
> {code}
> The integer division on the right side of  < would lose remainder, or fractional part of the quotient.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)