You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Alex Rodoni (Code Review)" <ge...@cloudera.org> on 2018/10/02 22:33:08 UTC
[Impala-ASF-CR] IMPALA-6634: [DOCS] Whitespace behavior in string to timestamp conversion
Alex Rodoni has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11567
Change subject: IMPALA-6634: [DOCS] Whitespace behavior in string to timestamp conversion
......................................................................
IMPALA-6634: [DOCS] Whitespace behavior in string to timestamp conversion
Noted that leading and trailing whitespaces are ignored when a string is
implicitly or explicitly converted to a timestamp.
Change-Id: Id5e485f0dccd2e6e1351d6d8194ec94c753f60b3
---
M docs/shared/impala_common.xml
M docs/topics/impala_literals.xml
2 files changed, 22 insertions(+), 19 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/67/11567/1
--
To view, visit http://gerrit.cloudera.org:8080/11567
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id5e485f0dccd2e6e1351d6d8194ec94c753f60b3
Gerrit-Change-Number: 11567
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
[Impala-ASF-CR] IMPALA-6634: [DOCS] Whitespace behavior in string to timestamp conversion
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11567 )
Change subject: IMPALA-6634: [DOCS] Whitespace behavior in string to timestamp conversion
......................................................................
Patch Set 1:
Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/87/
Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317
--
To view, visit http://gerrit.cloudera.org:8080/11567
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id5e485f0dccd2e6e1351d6d8194ec94c753f60b3
Gerrit-Change-Number: 11567
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 02 Oct 2018 22:33:16 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6634: [DOCS] Whitespace behavior in string to timestamp conversion
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11567 )
Change subject: IMPALA-6634: [DOCS] Whitespace behavior in string to timestamp conversion
......................................................................
IMPALA-6634: [DOCS] Whitespace behavior in string to timestamp conversion
Noted that leading and trailing whitespaces are ignored when a string is
implicitly or explicitly converted to a timestamp.
Change-Id: Id5e485f0dccd2e6e1351d6d8194ec94c753f60b3
Reviewed-on: http://gerrit.cloudera.org:8080/11567
Tested-by: Impala Public Jenkins <im...@cloudera.com>
Reviewed-by: Tim Armstrong <ta...@cloudera.com>
---
M docs/shared/impala_common.xml
M docs/topics/impala_literals.xml
2 files changed, 22 insertions(+), 19 deletions(-)
Approvals:
Impala Public Jenkins: Verified
Tim Armstrong: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/11567
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Id5e485f0dccd2e6e1351d6d8194ec94c753f60b3
Gerrit-Change-Number: 11567
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-6634: [DOCS] Whitespace behavior in string to timestamp conversion
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11567 )
Change subject: IMPALA-6634: [DOCS] Whitespace behavior in string to timestamp conversion
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/11567
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id5e485f0dccd2e6e1351d6d8194ec94c753f60b3
Gerrit-Change-Number: 11567
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 02 Oct 2018 23:31:43 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6634: [DOCS] Whitespace behavior in string to timestamp conversion
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11567 )
Change subject: IMPALA-6634: [DOCS] Whitespace behavior in string to timestamp conversion
......................................................................
Patch Set 1: Verified+1
Build Successful
https://jenkins.impala.io/job/gerrit-docs-auto-test/87/ : Doc tests passed.
--
To view, visit http://gerrit.cloudera.org:8080/11567
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id5e485f0dccd2e6e1351d6d8194ec94c753f60b3
Gerrit-Change-Number: 11567
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 02 Oct 2018 23:21:16 +0000
Gerrit-HasComments: No