[jira] [Commented] (CASSANDRA-13222) Paging with reverse queries and static columns may return incorrectly sized pages

["Jason Brown (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CASSANDRA-13222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15869891#comment-15869891 ] 

Jason Brown commented on CASSANDRA-13222:
-----------------------------------------

3.0 dtest hadn't run yet so I kicked it off. The 2.1/2.2 dtests have failures wrt the paging test:

{code}
"'TestPagingData' object has no attribute 'create_ks'
{code}

That appears to be an incorrectly written dtest. I'll submit a PR to fix that later.

I'm +1 on the code. The only tiny nit I would have is to add a comment to the 3.0+ versions of {{QueryPagerTest#pagingReversedQueriesWithStaticColumnsTest}} to indicate that we had a problem with reverse paging/statics/et al in pre-3.0, but that it shouldn't be problem now (and the test is to make sure everything stays legit into the future).

As for which versions to commit to, this doesn't seem critical enough for 2.1, so let's do 2.2+.

> Paging with reverse queries and static columns may return incorrectly sized pages
> ---------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-13222
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-13222
>             Project: Cassandra
>          Issue Type: Bug
>          Components: CQL, Local Write-Read Paths
>            Reporter: Sam Tunnicliffe
>            Assignee: Sam Tunnicliffe
>
> There are 2 specialisations of {{ColumnCounter}} that deal with static columns differently depending on the order of iteration through the column family and which impl is used generally depends on whether or not the {{ColumnFilter}} in use is reversed. However, the base method {{ColumnCounter::countAll}} always uses forward iteration, which can result in overcounting when the query is reversed and there are statics involved. In turn, this leads to incorrectly sized pages being returned to the client.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)