You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by swatkatz <gi...@git.apache.org> on 2017/02/08 00:52:45 UTC
[GitHub] thrift pull request #1178: THRIFT-4072 php: TCurlClient - Add the possibilit...
GitHub user swatkatz opened a pull request:
https://github.com/apache/thrift/pull/1178
THRIFT-4072 php: TCurlClient - Add the possibility to send custom hea\u2026
\u2026ders
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/swatkatz/thrift master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/1178.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1178
----
commit efe415acb0a295463be0ce83d1b2fe9425c593fb
Author: Swati Kumar <sw...@thumbtack.com>
Date: 2017-02-08T00:43:45Z
THRIFT-4072 php: TCurlClient - Add the possibility to send custom headers
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request #1178: THRIFT-4072 php: TCurlClient - Add the possibilit...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/thrift/pull/1178
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift issue #1178: THRIFT-4072 php: TCurlClient - Add the possibility to se...
Posted by Jens-G <gi...@git.apache.org>.
Github user Jens-G commented on the issue:
https://github.com/apache/thrift/pull/1178
@swatkatz: Having a test is better than not having one. We have way too many patches without tests, so if you provide one, we increase quality standards (and you will be our positive role model \U0001f44d) How awesome is that?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift issue #1178: THRIFT-4072 php: TCurlClient - Add the possibility to se...
Posted by jeking3 <gi...@git.apache.org>.
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1178
Would it be possible to add a unit test for this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift issue #1178: THRIFT-4072 php: TCurlClient - Add the possibility to se...
Posted by swatkatz <gi...@git.apache.org>.
Github user swatkatz commented on the issue:
https://github.com/apache/thrift/pull/1178
@jeking3 : I can add the tests as you suggest, but since this is a minor feature improvement and there don't seem to be any tests that exist for this class (and I see that other such patches don't have them either e.g. https://github.com/apache/thrift/commit/1f9717d192137d06927846cc2f2f7e380e5da834), I was just wondering what the standard practice around this was?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift issue #1178: THRIFT-4072 php: TCurlClient - Add the possibility to se...
Posted by swatkatz <gi...@git.apache.org>.
Github user swatkatz commented on the issue:
https://github.com/apache/thrift/pull/1178
thank you @jeking3 and @Jens-G .. I will give a shot at adding tests for this class in a separate PR. Also, thank you for letting me the correct way of setting up the PRs. Really appreciate the guidance.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift issue #1178: THRIFT-4072 php: TCurlClient - Add the possibility to se...
Posted by jeking3 <gi...@git.apache.org>.
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1178
If the class has no testing at all then I would not require you to add tests in order to get committed, however as Jens suggested it would improve the quality of the project if tests were put in, so I always ask.
It looks like you are making modifications in your master branch and they are getting sync'd into this pull request. In the future I would recommend that you create a branch off master first, like "git checkout -b THRIFT-4072" and then submit a pull request from that branch instead so it is isolated from the changes in your master. There should only be one commit for your changes... it looks like the way you have it set up, every time the apache master is revised your pull request will rebuild here, which is a bit heavy.
If the previous build was clean I can merge this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---