You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/07/31 08:57:10 UTC

[GitHub] [spark] gaborgsomogyi commented on pull request #28623: [SPARK-31805][SS] Exclude group.id from consumer settings when using the assign strategy

gaborgsomogyi commented on pull request #28623:
URL: https://github.com/apache/spark/pull/28623#issuecomment-667014944


   I'm just revisiting this. At the moment working on SPARK-32032 where `AdminClient` is planned to use on driver side which makes `group.id` completely useless in the Kafka connector. If it's merged then we can go to this direction but not with the current implementation. I think we shouldn't remove `group.id` from the map but just remove code references which are using it (for instance in `KafkaDataConsumer`).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org