You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "sebbASF (via GitHub)" <gi...@apache.org> on 2024/07/30 19:59:17 UTC

[PR] CODEC-182 - Sha2Crypt: tidy up salt Javadoc and validation. [commons-codec]

sebbASF opened a new pull request, #301:
URL: https://github.com/apache/commons-codec/pull/301

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] CODEC-182 - Sha2Crypt: tidy up salt Javadoc and validation. [commons-codec]

Posted by "sebbASF (via GitHub)" <gi...@apache.org>.
sebbASF commented on PR #301:
URL: https://github.com/apache/commons-codec/pull/301#issuecomment-2265685570

   If the extra validation rejects a mismatched prefix, that may cause an application to fail.
   Also the PR does not address the original reason for the Jira, i.e. the salt is not a 'real' salt.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] CODEC-182 - Sha2Crypt: tidy up salt Javadoc and validation. [commons-codec]

Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory commented on PR #301:
URL: https://github.com/apache/commons-codec/pull/301#issuecomment-2265636757

   Is there anything else needed to move this out of the draft stage?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org