[jira] [Commented] (SLING-2389) Separate request/access logging from the Sling Engine

["Felix Meschberger (Commented) (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SLING-2389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13198671#comment-13198671 ] 

Felix Meschberger commented on SLING-2389:
------------------------------------------

Fixes in Rev. 1239517
  - Install request logging as a Servlet API filter to catch all requests
  - Add a new log parameter 'y' to emit the HttpServletRequest.getAuthType()
  - Refactor RequestLogger to register RequestLoggerService instances according to the
     request and access log configuration
  - RequestLoggerFilter is only active if at least one RequestLoggerService is registered
  - RequestLoggerFilter takes no configuration

This is still part of the Sling Engine bundle.

It currently uses the following data apart from data gathered in its own Request/Response wrappers:
  - "org.osgi.service.http.authentication.remote.user" request attribute set by the OSGi HttpContext implementation for the %u (RemoteUser) parameter
  - "org.osgi.service.http.authentication.type" request attribute set by the OSGi HttpContext implementation for the %y (AuthType) parameter
  - "$$sling.request.resource$$" request attribute for the %f (Content/Resource Path) parameter (this is Sling Engine specific)
                
> Separate request/access logging from the Sling Engine
> -----------------------------------------------------
>
>                 Key: SLING-2389
>                 URL: https://issues.apache.org/jira/browse/SLING-2389
>             Project: Sling
>          Issue Type: Improvement
>          Components: Commons, Engine
>    Affects Versions: Engine 2.2.4
>            Reporter: Felix Meschberger
>             Fix For: Engine 2.2.6
>
>
> Currently the request and access log entries are generated in the Sling Engine bundle. The consequence of this is, that only requests going through the Sling Main Servlet are actually logged.
> The fix is to hook the request and access logging infrastructure into the serlvet container as a Servlet API Filter such as to run it as early and late as possible and more importantly on a global level to catch all requests.
> In addition, since this filter has nothing to do with the Sling Engine, it would make sense to create a bundle in the commons area along with the commons/log and commons/logservice bundles.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira