[GitHub] [spark] dongjoon-hyun commented on a change in pull request #25388: [SPARK-28656][SQL] Support `millennium`, `century` and `decade` at `extract()`

[GitBox <gi...@apache.org>]

dongjoon-hyun commented on a change in pull request #25388: [SPARK-28656][SQL] Support `millennium`, `century` and `decade` at `extract()`
URL: https://github.com/apache/spark/pull/25388#discussion_r312240435
 
 

 ##########
 File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/FunctionRegistry.scala
 ##########
 @@ -417,6 +417,9 @@ object FunctionRegistry {
     expression[TimeWindow]("window"),
     expression[MakeDate]("make_date"),
     expression[MakeTimestamp]("make_timestamp"),
+    expression[Millennium]("millennium"),
+    expression[Century]("century"),
+    expression[Decade]("decade"),
 
 Review comment:
   If this is not support in PostgreSQL, I'd like to recommend to remove these.
   
   cc @gatorsmile 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org