You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/09/20 20:38:15 UTC

[GitHub] [flink-statefun] igalshilman opened a new pull request #156: [FLINK-19296][http] Do not retry HTTP calls on shutdown

igalshilman opened a new pull request #156:
URL: https://github.com/apache/flink-statefun/pull/156


   Currently an HTTP request to a remote function would be retrying until the maximum timeout elapses, however during a task cancelation there is no need in retrying and we can short circuit immediately.
   This PR addressed that issue by propagating a shutdown flag to a `RetryingCallback`


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink-statefun] tzulitai closed pull request #156: [FLINK-19296][http] Do not retry HTTP calls on shutdown

Posted by GitBox <gi...@apache.org>.
tzulitai closed pull request #156:
URL: https://github.com/apache/flink-statefun/pull/156


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink-statefun] tzulitai commented on pull request #156: [FLINK-19296][http] Do not retry HTTP calls on shutdown

Posted by GitBox <gi...@apache.org>.
tzulitai commented on pull request #156:
URL: https://github.com/apache/flink-statefun/pull/156#issuecomment-695902793


   LGTM! Thanks @igalshilman, merging this.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink-statefun] tzulitai closed pull request #156: [FLINK-19296][http] Do not retry HTTP calls on shutdown

Posted by GitBox <gi...@apache.org>.
tzulitai closed pull request #156:
URL: https://github.com/apache/flink-statefun/pull/156


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink-statefun] tzulitai commented on pull request #156: [FLINK-19296][http] Do not retry HTTP calls on shutdown

Posted by GitBox <gi...@apache.org>.
tzulitai commented on pull request #156:
URL: https://github.com/apache/flink-statefun/pull/156#issuecomment-695902793


   LGTM! Thanks @igalshilman, merging this.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org