You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2022/04/12 14:01:36 UTC
[GitHub] [camel-k] squakez opened a new pull request, #3197: chore(deps): operator-framework
squakez opened a new pull request, #3197:
URL: https://github.com/apache/camel-k/pull/3197
<!-- Description -->
<!--
Enter your extended release note in the below block. If the PR requires
additional action from users switching to the new release, include the string
"action required". If no release note is required, write "NONE".
You can (optionally) mark this PR with labels "kind/bug" or "kind/feature" to make sure
the text is added to the right section of the release notes.
-->
**Release Note**
```release-note
chore(deps): library upgrade
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] squakez commented on a diff in pull request #3197: chore(deps): library upgrade
Posted by GitBox <gi...@apache.org>.
squakez commented on code in PR #3197:
URL: https://github.com/apache/camel-k/pull/3197#discussion_r849289730
##########
pkg/util/olm/operator.go:
##########
@@ -122,7 +123,7 @@ func HasPermissionToInstall(ctx context.Context, client client.Client, namespace
}
if !global {
- if ok, err := kubernetes.CheckPermission(ctx, client, operatorsv1.GroupName, "operatorgroups", namespace, options.Package, "list"); err != nil {
Review Comment:
The `v1alpha1` is using `operators.GroupName` behind the scene: https://github.com/operator-framework/api/blob/v0.13.0/pkg/operators/v1alpha1/register.go#L13 - I'd be inclined to keep this value as it is the value expected by that package and let the API manages. WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] astefanutti commented on a diff in pull request #3197: chore(deps): library upgrade
Posted by GitBox <gi...@apache.org>.
astefanutti commented on code in PR #3197:
URL: https://github.com/apache/camel-k/pull/3197#discussion_r849291661
##########
pkg/util/olm/operator.go:
##########
@@ -122,7 +123,7 @@ func HasPermissionToInstall(ctx context.Context, client client.Client, namespace
}
if !global {
- if ok, err := kubernetes.CheckPermission(ctx, client, operatorsv1.GroupName, "operatorgroups", namespace, options.Package, "list"); err != nil {
Review Comment:
Yes, that's sounds good, it's not a big deal.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] squakez commented on pull request #3197: chore(deps): library upgrade
Posted by GitBox <gi...@apache.org>.
squakez commented on PR #3197:
URL: https://github.com/apache/camel-k/pull/3197#issuecomment-1097690492
@astefanutti would you mind having a look at this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] squakez merged pull request #3197: chore(deps): library upgrade
Posted by GitBox <gi...@apache.org>.
squakez merged PR #3197:
URL: https://github.com/apache/camel-k/pull/3197
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] astefanutti commented on a diff in pull request #3197: chore(deps): library upgrade
Posted by GitBox <gi...@apache.org>.
astefanutti commented on code in PR #3197:
URL: https://github.com/apache/camel-k/pull/3197#discussion_r849215669
##########
pkg/util/olm/operator.go:
##########
@@ -122,7 +123,7 @@ func HasPermissionToInstall(ctx context.Context, client client.Client, namespace
}
if !global {
- if ok, err := kubernetes.CheckPermission(ctx, client, operatorsv1.GroupName, "operatorgroups", namespace, options.Package, "list"); err != nil {
Review Comment:
Maybe `operatorsv1.GroupVersion.Group`, or use `operators.GroupName` also for the v1alpha1 APIs above for consistency?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org