You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by jeking3 <gi...@git.apache.org> on 2016/10/05 18:50:28 UTC
[GitHub] thrift pull request #1109: THRIFT-3943: resolve some high severity outstandi...
GitHub user jeking3 opened a pull request:
https://github.com/apache/thrift/pull/1109
THRIFT-3943: resolve some high severity outstanding defects identified by coverity scan
https://scan7.coverity.com/reports.htm#v15415/p10216/fileInstanceId=3547531&defectInstanceId=1023429&mergedDefectId=748818
Coverity Scan identified 9 issues of high severity.
I dismissed 4 of them as false positives; coverity lost track of the handling of socket file descriptors across multiple layers of calls; this left 5 issues:
1295822 - memory leak in ThreadFactoryTests
1216842 - uninitialized rfds fd_set is passed to select if mode is not WAIT_MODE_C (R+W)
1216841 - uninitialized wfds fd_set is passed to select if mode is not WAIT_MODE_C (R+W)
1216840 - getsockname is always passed uninitialized addrlen
1174563 - memory leak in compiler class handling functions
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jeking3/thrift defect/THRIFT-3943
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/1109.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1109
----
commit fc06e472cdd901e9273936e323efc85e694e7b32
Author: James E. King, III <ji...@simplivity.com>
Date: 2016-10-05T18:47:18Z
THRIFT-3943: resolve some high severity outstanding defects identified by coverity scan
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift issue #1109: THRIFT-3943: resolve some high severity outstanding defe...
Posted by jeking3 <gi...@git.apache.org>.
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1109
Well, putting in that delete of xceptions_ certainly didn't fare well.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift issue #1109: THRIFT-3943: resolve some high severity outstanding defe...
Posted by jeking3 <gi...@git.apache.org>.
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1109
I backed out the delete _xcception change in the compiler (1174563 - memory leak in compiler class handling functions), we'll see if that was the culprit.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request #1109: THRIFT-3943: resolve some high severity outstandi...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/thrift/pull/1109
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---