[GitHub] [deltaspike] SethFalco commented on pull request #109: Support for Additional Converters by Default

[GitBox <gi...@apache.org>]

SethFalco commented on pull request #109:
URL: https://github.com/apache/deltaspike/pull/109#issuecomment-927151911


   Hey! Understood, I'll squash this PR and match the improvements suggested from BeanUtils.
   Even if this won't be merged as is, the logic should still be updated anyway.
   
   Meanwhile, having implicit converters seems cool.
   
   This PR includes 5 converters that would be made redundant, assuming we stuck with the current implementations.
   * [Duration](https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/time/Duration.html) ([`Duration#parse`](https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/time/Duration.html#parse(java.lang.CharSequence)))
   * [File](https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/io/File.html) ([`File::new`](https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/io/File.html#%3Cinit%3E(java.lang.String)))
   * [Instant](https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/time/Instant.html) ([`Instant#parse`](https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/time/Instant.html#parse(java.lang.CharSequence)))
   * [Period](https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/time/Period.html) ([`Period#parse`](https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/time/Period.html#parse(java.lang.CharSequence)))
   * [URI](https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/net/URI.html) ([`URI::new`](https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/net/URI.html#%3Cinit%3E(java.lang.String)))
   
   Just a note, but something that could've been implicit, but doesn't meet the current spec is `#fromString`?
   But only the following have it in the standard library:
   * [UUID](https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/util/UUID.html) ([`UUID#fromString`](https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/util/UUID.html#fromString(java.lang.String)))
   * [PosixFilePermissions](https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/nio/file/attribute/PosixFilePermissions.html) ([`PosixFilePermissions#fromString`](https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/nio/file/attribute/PosixFilePermissions.html#fromString(java.lang.String)))


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@deltaspike.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org