You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@tsfile.apache.org by "jt2594838 (via GitHub)" <gi...@apache.org> on 2025/04/24 07:23:42 UTC
[PR] Remove redundant conversion in TableResultSet [tsfile]
jt2594838 opened a new pull request, #473:
URL: https://github.com/apache/tsfile/pull/473
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@tsfile.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove redundant conversion in TableResultSet [tsfile]
Posted by "HTHou (via GitHub)" <gi...@apache.org>.
HTHou merged PR #473:
URL: https://github.com/apache/tsfile/pull/473
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@tsfile.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove redundant conversion in TableResultSet [tsfile]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #473:
URL: https://github.com/apache/tsfile/pull/473#discussion_r2057798939
##########
java/tsfile/src/main/java/org/apache/tsfile/read/common/block/column/BinaryColumn.java:
##########
@@ -146,7 +146,7 @@ public boolean mayHaveNull() {
@Override
public boolean isNull(int position) {
- return valueIsNull != null && valueIsNull[position + arrayOffset];
+ return values[position] == null || valueIsNull != null && valueIsNull[position + arrayOffset];
Review Comment:
Verify if the access to the values array should consider the arrayOffset (i.e., values[position + arrayOffset]) to maintain consistency with the null check performed on valueIsNull.
```suggestion
return values[position + arrayOffset] == null || valueIsNull != null && valueIsNull[position + arrayOffset];
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@tsfile.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org